From owner-dev-commits-src-all@freebsd.org Mon Jun 28 21:43:16 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1A7AD65CE0C; Mon, 28 Jun 2021 21:43:16 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GDLh40BRjz4gpc; Mon, 28 Jun 2021 21:43:15 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-il1-f170.google.com with SMTP id s19so18895139ilj.1; Mon, 28 Jun 2021 14:43:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d9Yy2YA9gIfwdsuOGolyNa3TzVpMEO/12CGQMRiSJAI=; b=gvpaeW1d9ltFDcjTjh7CitLGHZjvtZ/cuH9gobjqb13jPDsA5RUyECC8Zyvgm7SL41 ykAf8znEPmK1bOYqq5LFe1dx9TIH8UxBJkHmV+npRN42HfifmWSywbVZrD+DW4ZxAC5Q +uq/OUvy7MoiNYD9PzmWUPpfYDesBfYf/wEDo6O00k4mxQSKH3/LvJ1nQ3lv5ngNGxcn XrPJVbVltbTfPTxpBmXqS40Aal7gWZZl6E3awd0YNPF2pqCdMzENC8t4lbfNE34L7tHo K4qsnKxPo8fZpXSsOvUoBoUZ6aIa7a+FfAB/Yb3pNdHRTAgqK+W7G//EYIo7P8JEbqpO uNvg== X-Gm-Message-State: AOAM530ds2kZKm+YRwl1GfmD+nAocnFR9wvDx7fF7rrDRvhpHW6UEDz8 PBDUgRRQidTzJVapdDvnf4f7dMnxkRrDmdyhwPwxy1Jj+p0= X-Google-Smtp-Source: ABdhPJyyvC4s4govB3aUgM/yEUk0YkJaAcQIHc1CJo9vMOqKIf3ScDX2KGaJttRUwYlSCgNCnMctjlye4bvBUDUGntg= X-Received: by 2002:a92:d0d1:: with SMTP id y17mr10464257ila.256.1624916594271; Mon, 28 Jun 2021 14:43:14 -0700 (PDT) MIME-Version: 1.0 References: <202106281537.15SFbdiG002780@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Mon, 28 Jun 2021 17:42:52 -0400 Message-ID: Subject: Re: git: 175841285e28 - main - Add deprecation notice for WITH_PROFILE option To: Kyle Evans Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4GDLh40BRjz4gpc X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 21:43:16 -0000 On Mon, 28 Jun 2021 at 16:01, Kyle Evans wrote: > > On Mon, Jun 28, 2021 at 12:57 PM Ed Maste wrote: > > > > How about "The PROFILE functionality is not available in .Fx 14."? > > +1, I like that. Hrm, I think I don't need a note in WITHOUT_PROFILE in fact. I added it originally because I thought PROFILE was on by default for all archs on stable branches, which would have only WITHOUT_PROFILE in src.conf.5. However, mips64 lacks PROFILE support so both are listed - thus with a note in WITH_PROFILE only we'd have: WITHOUT_PROFILE Do not build profiled libraries for use with gprof(8). This is a default setting on mips/mips64. WITH_PROFILE Build profiled libraries for use with gprof(8). This option is deprecated and is not present in FreeBSD 14. This is a default setting on amd64/amd64, arm/armv6, arm/armv7, arm64/aarch64, i386/i386, mips/mips, powerpc/powerpc, powerpc/powerpc64, riscv/riscv64 and riscv/riscv64sf. which I think is sufficient.