From owner-svn-src-all@FreeBSD.ORG Thu Mar 4 03:36:46 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B656D1065670; Thu, 4 Mar 2010 03:36:46 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 53EAE8FC12; Thu, 4 Mar 2010 03:36:45 +0000 (UTC) Received: from [IPv6:::1] (pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id o243afF8044395; Wed, 3 Mar 2010 20:36:42 -0700 (MST) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Scott Long In-Reply-To: <200906152105.n5FL50Ju001949@svn.freebsd.org> Date: Wed, 3 Mar 2010 20:36:41 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <200906152105.n5FL50Ju001949@svn.freebsd.org> To: Ed Schouten X-Mailer: Apple Mail (2.1077) X-Spam-Status: No, score=-4.4 required=3.8 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r194266 - head/usr.bin/chpass X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2010 03:36:46 -0000 Forcing the entire build to fail if chflags fails breaks installing to = an NFS destination. I haven't tested all possible permutations of src = vs dest filesystems mounting, but I don't see how it can work over any = type of NFS mount. What is the reason for forcing this failure? The = NO_FSCHG variable is undocumented, and the failure mode here is pretty = useless at helping the user fix the problem. I'd like to re-add the '-' = modifier to the chflags command that you removed. Scott On Jun 15, 2009, at 3:05 PM, Ed Schouten wrote: > Author: ed > Date: Mon Jun 15 21:05:00 2009 > New Revision: 194266 > URL: http://svn.freebsd.org/changeset/base/194266 >=20 > Log: > Make the chpass Makefile honour NO_FSCHG. >=20 > The chpass Makefile tried to set the fschg flag on the binaries, even = if > NO_FSCHG was passed to the installworld. This meant that if I = installed > FreeBSD into a Jail, I couldn't installworld from within the Jail > anymore. >=20 > Now that it listens to NO_FSCHG, we can just make it bail out when it > fails, just like PRECIOUSPROG does. >=20 > Modified: > head/usr.bin/chpass/Makefile >=20 > Modified: head/usr.bin/chpass/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/usr.bin/chpass/Makefile Mon Jun 15 21:03:25 2009 = (r194265) > +++ head/usr.bin/chpass/Makefile Mon Jun 15 21:05:00 2009 = (r194266) > @@ -39,11 +39,12 @@ MLINKS+=3D chpass.1 ypchpass.1 chpass.1 yp >=20 > beforeinstall: > .for i in chpass chfn chsh ypchpass ypchfn ypchsh > - [ ! -e ${DESTDIR}${BINDIR}/$i ] || \ > - chflags noschg ${DESTDIR}${BINDIR}/$i || true > + -chflags noschg ${DESTDIR}${BINDIR}/$i > .endfor >=20 > +.if !defined(NO_FSCHG) > afterinstall: > - -chflags schg ${DESTDIR}${BINDIR}/chpass > + chflags schg ${DESTDIR}${BINDIR}/chpass > +.endif >=20 > .include