From nobody Sun Jun 21 11:48:04 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gjqMm3ZCMz6jZW5 for ; Sun, 21 Jun 2026 11:48:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gjqMm1dFZz3W2p for ; Sun, 21 Jun 2026 11:48:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782042484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=l9uhf+EprbKPMJkFECYILfDFG41Bgm92MZ4MrKId/Qs=; b=u7reo9o9rihoewULJK9x0baAFW0sds8ihNs5pKr01s1s68OzYjS2JkRyZweFr+BT5xJ7JK G+SqTOtz8jQejLaJHRFNl4Lf/MrClIJOBr3f4TnC/gRGVZeOWuq6G8z18LyNJtmz5+f0mA qB4GgMvUuzf/jYEhOJiNA3C2Clq+Vi1/cC+HkO/wvSDD3vIQeAPzce8nktLm/iMRtnUKpk BxqWxRNlbX5oQ7KJac/gnX1LuwrNysHeYRuQ4e5wuLz4vTUugjHPYHB7f++BOw9ek3r3pV HfPbHVVODNO4516f/ojfbaKF+1rQyYpt+wl+DArXlMHRSPwdFZ5rsbH9qN84IA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782042484; a=rsa-sha256; cv=none; b=n5fFp6WC9MsEgRLca9OJyvRhH1I4zp+jYjyREh37gSuSXhpAzBcbFKkugPfcmOgRZvD97r NfRtvedbiQe2qvEsOikNYOv+MXBfZhOpYk3Hfh9MEPko+OzOCngFmVKwmObdmu3xsejWTC fRD00kbXCk8jo7kPRsfqn38aVDqw9s1FSRnRaMpc9PtQ2ORjrAagC+v7GVZ8ofHQoZiikt 2qSpqcq+WQTVuVTUJaiztBxuQ5eQNWQKs+O/V1VueauXDASrTLbyKsNvcf9nRX+v1UuFyi fw0ke6pxF5zdynTVDuEj7+0R5E0mDI5AEjqXyw2G7fDINpPOxLvFxVBzT7luCA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782042484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=l9uhf+EprbKPMJkFECYILfDFG41Bgm92MZ4MrKId/Qs=; b=MEhBveEKV5hHNnAPD5BfLsiR/hsN3DQxDAq7I5AxcKVNcyBSOwNj2G0vd1bD4FFMNEhemq 5RsGMEBTzr01UN3eoouHECi21kPDuffsFAPMZUTWqErCufXmfQepqsBycEl38C2FHgbcZb 37COZAL6qsZL8D+EuZmAtboBNE/fqJQWbR8lTxoGohq3aTjdAt3icTg29zFV8Qnihkx/k9 6BOktz6Dm2YKkx5PHxK8YCseG1/i8DtlSNxDZQXF9XzoUop68JvrOtzYrWqXmkiIhZPolf gwE6hxqTFR5NTl3ix7cz35p+s1jxIq6f3QCkH64SSV2Vpwghj44V6cEwT7n31w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gjqMm09q2z1DfC for ; Sun, 21 Jun 2026 11:48:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 25061 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 21 Jun 2026 11:48:04 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 31fa677e4af0 - main - kern_proc.c: ensure stability of the vmspace for sysctl kern.proc.vm_layout List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 31fa677e4af00b795bf671847b4dc72960c90f14 Auto-Submitted: auto-generated Date: Sun, 21 Jun 2026 11:48:04 +0000 Message-Id: <6a37cf74.25061.46828b52@gitrepo.freebsd.org> The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=31fa677e4af00b795bf671847b4dc72960c90f14 commit 31fa677e4af00b795bf671847b4dc72960c90f14 Author: Konstantin Belousov AuthorDate: 2026-06-14 23:49:20 +0000 Commit: Konstantin Belousov CommitDate: 2026-06-21 11:46:53 +0000 kern_proc.c: ensure stability of the vmspace for sysctl kern.proc.vm_layout Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D57497 --- sys/kern/kern_proc.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_proc.c b/sys/kern/kern_proc.c index 1fff6e5629ea..a42d528cc9c1 100644 --- a/sys/kern/kern_proc.c +++ b/sys/kern/kern_proc.c @@ -3290,6 +3290,7 @@ sysctl_kern_proc_vm_layout(SYSCTL_HANDLER_ARGS) { struct kinfo_vm_layout kvm; struct proc *p; + struct thread *td; struct vmspace *vmspace; int error, *name; @@ -3297,6 +3298,7 @@ sysctl_kern_proc_vm_layout(SYSCTL_HANDLER_ARGS) if ((u_int)arg2 != 1) return (EINVAL); + td = curthread; error = pget((pid_t)name[0], PGET_CANDEBUG, &p); if (error != 0) return (error); @@ -3308,8 +3310,13 @@ sysctl_kern_proc_vm_layout(SYSCTL_HANDLER_ARGS) } } #endif - vmspace = vmspace_acquire_ref(p); + _PHOLD(p); PROC_UNLOCK(p); + error = proc_vmspace_ref(td, p, PRVM_CHECK_DEBUG, &vmspace); + if (error != 0) { + PRELE(p); + return (error); + } memset(&kvm, 0, sizeof(kvm)); kvm.kvm_min_user_addr = vm_map_min(&vmspace->vm_map); @@ -3361,7 +3368,8 @@ sysctl_kern_proc_vm_layout(SYSCTL_HANDLER_ARGS) #ifdef COMPAT_FREEBSD32 out: #endif - vmspace_free(vmspace); + proc_vmspace_unref(td, p, PRVM_CHECK_DEBUG, vmspace); + PRELE(p); return (error); }