From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Sep 21 20:39:21 2005
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@hub.freebsd.org
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5EE3416A41F;
	Wed, 21 Sep 2005 20:39:21 +0000 (GMT)
	(envelope-from thierry@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0F70943D49;
	Wed, 21 Sep 2005 20:39:21 +0000 (GMT)
	(envelope-from thierry@FreeBSD.org)
Received: from freefall.freebsd.org (thierry@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8LKdK84071592;
	Wed, 21 Sep 2005 20:39:20 GMT
	(envelope-from thierry@freefall.freebsd.org)
Received: (from thierry@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8LKdKpC071588;
	Wed, 21 Sep 2005 20:39:20 GMT (envelope-from thierry)
Date: Wed, 21 Sep 2005 20:39:20 GMT
From: Thierry Thomas <thierry@FreeBSD.org>
Message-Id: <200509212039.j8LKdKpC071588@freefall.freebsd.org>
To: nivit@email.it, thierry@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org,
	thierry@FreeBSD.org
Cc: 
Subject: Re: ports/85801: [NEW PORT] math/geogebra-i18n: A dynamic software
	that joins geometry, algebra and calculus
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Sep 2005 20:39:21 -0000

Synopsis: [NEW PORT] math/geogebra-i18n: A dynamic software that joins geometry, algebra and calculus

State-Changed-From-To: open->feedback
State-Changed-By: thierry
State-Changed-When: Wed Sep 21 20:33:18 GMT 2005
State-Changed-Why: 

This port is fine, but I would just make a minor suggestion: since
DISTNAME is not versioned, it would be easier to maintain if we include
PORTVERSION in DIST_SUBDIR. Could you please review the following patch?

--- geogebra-i18n.diff begins here ---
diff -urN math/geogebra-i18n.orig/Makefile math/geogebra-i18n/Makefile
--- math/geogebra-i18n.orig/Makefile	Wed Sep 21 22:22:06 2005
+++ math/geogebra-i18n/Makefile	Wed Sep 21 22:25:23 2005
@@ -12,7 +12,7 @@
 MASTER_SITES=	http://www.geogebra.at/download/InstData/Java/
 DISTNAME=	geogebra_setup
 EXTRACT_SUFX=	.jar
-DIST_SUBDIR=	${PORTNAME}
+DIST_SUBDIR=	${PORTNAME}-${PORTVERSION}
 
 MAINTAINER=	nivit@email.it
 COMMENT=	A dynamic software that joins geometry, algebra and calculus
@@ -33,8 +33,6 @@
 SOURCES_DIR=	${WRKSRC}/D_/deploy/source
 JARFILE=	${PORTNAME:S/-i18n$//}.jar
 
-.include <bsd.port.pre.mk>
-
 do-install:
 	${INSTALL_SCRIPT} ${WRKSRC}/${SUB_FILES} ${PREFIX}/bin/${SUB_FILES}
 	cd ${SOURCES_DIR} && ${MKDIR} ${DATADIR} && ${INSTALL_DATA} ${JARFILE} ${DATADIR};
@@ -44,4 +42,5 @@
 	cd ${SOURCES_DIR} && ${FIND} . ${FIND_DOCS} -exec ${INSTALL_DATA} {} ${DOCSDIR}/{} \;
 .endif
 	cd ${SOURCES_DIR}/.. && ${FIND} . ${FIND_ICONS} -exec ${INSTALL_DATA} {} ${DATADIR}/{} \;
-.include <bsd.port.post.mk>
+
+.include <bsd.port.mk>
diff -urN math/geogebra-i18n.orig/distinfo math/geogebra-i18n/distinfo
--- math/geogebra-i18n.orig/distinfo	Wed Sep 21 22:04:41 2005
+++ math/geogebra-i18n/distinfo	Wed Sep 21 22:26:03 2005
@@ -1,2 +1,2 @@
-MD5 (geogebra-i18n/geogebra_setup.jar) = 61589d1277c0687c1c5ceba9d21db173
-SIZE (geogebra-i18n/geogebra_setup.jar) = 5071911
+MD5 (geogebra-i18n-2.6b/geogebra_setup.jar) = 61589d1277c0687c1c5ceba9d21db173
+SIZE (geogebra-i18n-2.6b/geogebra_setup.jar) = 5071911
--- geogebra-i18n.diff ends here ---

Regards,


Responsible-Changed-From-To: freebsd-ports-bugs->thierry
Responsible-Changed-By: thierry
Responsible-Changed-When: Wed Sep 21 20:33:18 GMT 2005
Responsible-Changed-Why: 

Take it.


http://www.freebsd.org/cgi/query-pr.cgi?pr=85801