From owner-svn-src-all@FreeBSD.ORG  Fri Jan 22 04:53:09 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 25AE3106566B;
	Fri, 22 Jan 2010 04:53:09 +0000 (UTC) (envelope-from ed@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 1515B8FC15;
	Fri, 22 Jan 2010 04:53:09 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o0M4r8Sx051374;
	Fri, 22 Jan 2010 04:53:08 GMT (envelope-from ed@svn.freebsd.org)
Received: (from ed@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o0M4r8pi051372;
	Fri, 22 Jan 2010 04:53:08 GMT (envelope-from ed@svn.freebsd.org)
Message-Id: <201001220453.o0M4r8pi051372@svn.freebsd.org>
From: Ed Schouten <ed@FreeBSD.org>
Date: Fri, 22 Jan 2010 04:53:08 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r202778 - head/lib/libc/gen
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2010 04:53:09 -0000

Author: ed
Date: Fri Jan 22 04:53:08 2010
New Revision: 202778
URL: http://svn.freebsd.org/changeset/base/202778

Log:
  Remove comments about breaking the specification.
  
  I've discussed this issue with the Austin Group and it will be fixed in
  future revisions of the specification. The issue was that ut_line fields
  weren't supposed to be valid for LOGIN_PROCESS entries, while
  getutxline() would try to match these records anyway.
  
  They also agreed on our way of implementing pututxline() without
  getutxid() (which other operating systems also do), but unfortunately
  they disagreed with our way of replacing DEAD_PROCESS entries, which is
  a pity. The current specification allows the utmpx database to become
  infinitely big over time.
  
  See also:	http://austingroupbugs.net/view.php?id=213#c378

Modified:
  head/lib/libc/gen/utxdb.c

Modified: head/lib/libc/gen/utxdb.c
==============================================================================
--- head/lib/libc/gen/utxdb.c	Fri Jan 22 03:59:05 2010	(r202777)
+++ head/lib/libc/gen/utxdb.c	Fri Jan 22 04:53:08 2010	(r202778)
@@ -83,7 +83,6 @@ utx_to_futx(const struct utmpx *ut, stru
 	case LOGIN_PROCESS:
 		UTOF_ID(ut, fu);
 		UTOF_STRING(ut, fu, user);
-		/* XXX: bug in the specification? Needed for getutxline(). */
 		UTOF_STRING(ut, fu, line);
 		UTOF_PID(ut, fu);
 		break;
@@ -156,7 +155,6 @@ futx_to_utx(const struct futx *fu)
 	case LOGIN_PROCESS:
 		FTOU_ID(fu, ut);
 		FTOU_STRING(fu, ut, user);
-		/* XXX: bug in the specification? Needed for getutxline(). */
 		FTOU_STRING(fu, ut, line);
 		FTOU_PID(fu, ut);
 		break;