From owner-freebsd-bugs Wed Jun 25 09:13:02 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id JAA00596 for bugs-outgoing; Wed, 25 Jun 1997 09:13:02 -0700 (PDT) Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id JAA00590 for ; Wed, 25 Jun 1997 09:12:57 -0700 (PDT) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.8.5/8.8.5) id MAA23709; Wed, 25 Jun 1997 12:12:43 -0400 (EDT) Date: Wed, 25 Jun 1997 12:12:43 -0400 (EDT) From: Garrett Wollman Message-Id: <199706251612.MAA23709@khavrinen.lcs.mit.edu> To: sthaug@nethelp.no Cc: freebsd-bugs@hub.freebsd.org Subject: Re: kern/3925: SO_SNDLOWAT of 0 causes kernel to use 99% of CPU time on TCP send In-Reply-To: <199706250900.CAA11823@hub.freebsd.org> References: <199706250900.CAA11823@hub.freebsd.org> Sender: owner-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk < Modified Files: > uipc_socket.c > Log Message: > In sosetopt(): > - Disallow < 1 values for SO_SNDBUF, SO_RCVBUF, SO_SNDLOWAT, and > SO_RCVLOWAT; return EINVAL if the user attempts to set <= 0. > Inspired by PR #3770, from Havard Eidnes . > - For SO_SNDLOWAT and SO_RCVLOWAT, don't let the low-water mark get > set above the high-water mark. Behavior is now consistent with > BSD/OS: If such an attempt is made, silently truncate to the high-water > value. I believe this fix to be both reasonable and most likely applicable equally to our source base. Unfortunately I'm not in a position to test it right now... can anyone out there copy this change over? -GAWollman -- Garrett A. Wollman | O Siem / We are all family / O Siem / We're all the same wollman@lcs.mit.edu | O Siem / The fires of freedom Opinions not those of| Dance in the burning flame MIT, LCS, CRS, or NSA| - Susan Aglukark and Chad Irschick