From owner-svn-src-head@FreeBSD.ORG Mon Dec 17 16:40:06 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C8418CDB; Mon, 17 Dec 2012 16:40:06 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-ia0-f182.google.com (mail-ia0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6AB068FC0C; Mon, 17 Dec 2012 16:40:06 +0000 (UTC) Received: by mail-ia0-f182.google.com with SMTP id x2so5548323iad.13 for ; Mon, 17 Dec 2012 08:40:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=PXewVJAOszM7Eb3MxmvmFpzoFJKIto+ZpfPddZHz7UQ=; b=uioLazZBVV/r2a+H2i5OuPPh9OCBamqLniyPVGfgiQOrACwLiovhPInmD57R193slo g7fJjzCR1csBrPDTIj5Yh9F17gtuqTP4zB/P2UqjbrxFygfFK8X89cs90t5txSz3kUW5 zDiIyLGwBkwELe/8LgoZLR9ki9b+/mScVOXAeHP7vjc47PsTtiI5PJ6PBJfyJJEHQdX0 +aZ0RwD5uMwONF+8HNvhGLHFaCpELTX/g5U/yLkn+nA0UjVxQ9A8KVgSWerPVUxf3m4Z Ku5MiOYlGKBp6PvBG2BBXv/dwin4U72DU370XaWKa6EixA/60KWGsfXcHY4GSCTbHX+t /Xug== MIME-Version: 1.0 Received: by 10.50.220.166 with SMTP id px6mr9603833igc.8.1355762399887; Mon, 17 Dec 2012 08:39:59 -0800 (PST) Sender: carpeddiem@gmail.com Received: by 10.50.112.134 with HTTP; Mon, 17 Dec 2012 08:39:59 -0800 (PST) In-Reply-To: References: <201212150003.qBF03Zr0085865@svn.freebsd.org> Date: Mon, 17 Dec 2012 11:39:59 -0500 X-Google-Sender-Auth: 51oIczUy3laMbDQ12SqqR43QSGI Message-ID: Subject: Re: svn commit: r244236 - head/share/mk From: Ed Maste To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2012 16:40:06 -0000 On 14 December 2012 19:13, Garrett Cooper wrote: > On Fri, Dec 14, 2012 at 4:03 PM, Ed Maste wrote: >> Author: emaste >> Date: Sat Dec 15 00:03:35 2012 >> New Revision: 244236 >> URL: http://svnweb.freebsd.org/changeset/base/244236 > > ... > >> Modified: head/share/mk/sys.mk >> ============================================================================== >> --- head/share/mk/sys.mk Fri Dec 14 23:13:06 2012 (r244235) >> +++ head/share/mk/sys.mk Sat Dec 15 00:03:35 2012 (r244236) >> @@ -134,6 +134,8 @@ NM ?= nm >> OBJC ?= cc >> OBJCFLAGS ?= ${OBJCINCLUDES} ${CFLAGS} -Wno-import >> >> +OBJCOPY ?= objcopy >> + >> PC ?= pc >> PFLAGS ?= > > This shouldn't be defined when !defined(%POSIX) is true. The > .endif should be pulled down to just above SHELL?= according to what > I'm reading in http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html > . Thanks for pointing this out; unfortunately it seems we have a bit of a mess here already. For one example see bin/155000; it looks it's not even possible to correctly specify POSIX mode anyway. I'd like to see us grow support for a POSIX-sys.mk as bde mentions in 155000, and we could then do away with all of the .if goo. For now though I'll move the .endif down. > Other spots in the tree where OBJCOPY?= is noted can be probably > start to be reaped (thinking about sys/boot/, etc in particular). I > have a PR open for some work Warner started with an initial patch that > I've kind of been keeping up to date in git, but it needs to be > updated now per this change (and also because I didn't notice that > these variables weren't supposed to be defined when POSIX mode was > on). I'd think none of the other files should be affected by changes to support POSIX mode.