From owner-svn-src-all@freebsd.org Sat Jun 15 05:44:54 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0821115BCC5B; Sat, 15 Jun 2019 05:44:54 +0000 (UTC) (envelope-from unkadoug@gmail.com) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8DFCB8F17F; Sat, 15 Jun 2019 05:44:53 +0000 (UTC) (envelope-from unkadoug@gmail.com) Received: by mail-oi1-x236.google.com with SMTP id g7so3517598oia.8; Fri, 14 Jun 2019 22:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=X+Wojb+5EQe9Hu8Aykaa6blD1gyJPIkWCeCPNX6DwCE=; b=ozD1KyKlKrW3hW26fAkwaR/fEKUfDwTRNn6LzIWyenKYDUft1QNExSIgo0MsgU0Bsu dat1jUI/kyUO6jL6Qpt+vjYg65elsBEKmienZhQJZyqYheQER5YsXQBAD3YLfTZrA4WD P4A+dQ2H3KMqv6uYWSugVnsivl+HcXvK6JYHBAC4kiRp8gC+oXstYSVwFfDBZlLalvql TDWLJhCkSlR7jKvF5FnvlNY0xZBGlbzzCXrdH0c4xd82PA4t72Lk2E3B5MNPfNsetHbd 0OK50APgiGvPgX78jz8GXqomiqPDzk+mayEaKXxQRKi4lobjJosoA0L+22k7Y2bcBgkA 3aJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=X+Wojb+5EQe9Hu8Aykaa6blD1gyJPIkWCeCPNX6DwCE=; b=ruzBSSRMDReh8KAZ9ZsM7a6bUthhjC4kk6d/ouWPzDnxJeR+ml5QcskUT/KqBM0vl7 TF8b0ICJA9J4RO5oL+aNTqUuQ4Ja7KOs20e48eYRLi25nrTHIgdiG8XgjsfEPqSY3Q7c pQVAfRL9fGckP3bqvZ6CK2uYpaUyNd4uTLIGVtZDKqJvnvRE5dlPS4NW9AI9p4k07Cv6 LSEZNgsNSPVmi2kGwNwt+fcdY2Uc+O4nmnUuIEXCBUQYuvWg6q5TuLoDhbvDVJ93FaB2 v8zf22Tc8txtiq7+niR6OHBeqpJMnizkKfd//iWUgjbK4Vd4ok15eE3Ssacpox4oEHCW SdHA== X-Gm-Message-State: APjAAAXGlwt3nzgxwRJ/gH9N0Blv5fa6HzITB75/Z2lslnHVlughh9kC 8mqbyH1ydDHVDaUytjZfqRQdpIxV X-Google-Smtp-Source: APXvYqyWQGAYC6HEzbFJjKtXz9/R1lM+JxR6+nMsM8rW3losYXeFSQRpQH9VpGkmMIDOi4nf5vO3Gw== X-Received: by 2002:aca:b40b:: with SMTP id d11mr4164684oif.56.1560577492407; Fri, 14 Jun 2019 22:44:52 -0700 (PDT) Received: from 108-254-203-202.lightspeed.hstntx.sbcglobal.net (108-254-203-202.lightspeed.hstntx.sbcglobal.net. [108.254.203.202]) by smtp.gmail.com with ESMTPSA id m72sm97791oig.14.2019.06.14.22.44.51 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2019 22:44:51 -0700 (PDT) From: Doug Moore X-Google-Original-From: Doug Moore Subject: Re: svn commit: r349046 - head/sys/vm To: Oliver Pinter Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201906150430.x5F4UDVX031215@repo.freebsd.org> Message-ID: Date: Sat, 15 Jun 2019 00:44:50 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Rspamd-Queue-Id: 8DFCB8F17F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.968,0] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jun 2019 05:44:54 -0000 The patch makes it appear that a call to vm_map_simplify_entry has been removed, and that another has been added.  They are the same call, just moved from after a comment to before it. Doug Moore On 6/15/19 12:30 AM, Oliver Pinter wrote: > > > On Saturday, June 15, 2019, Doug Moore > wrote: > > Author: dougm > Date: Sat Jun 15 04:30:13 2019 > New Revision: 349046 > URL: https://svnweb.freebsd.org/changeset/base/349046 > > > Log: >   Critical comments were lost in r349203. This patch seeks to restore >   the lost information in new comments. > >   Reported by: alc >   Reviewed by: alc >   Approved by: kib (mentor) >   Differential Revision: https://reviews.freebsd.org/D20632 > > > Modified: >   head/sys/vm/vm_map.c > > Modified: head/sys/vm/vm_map.c > ============================================================================== > --- head/sys/vm/vm_map.c        Sat Jun 15 01:27:49 2019        > (r349045) > +++ head/sys/vm/vm_map.c        Sat Jun 15 04:30:13 2019        > (r349046) > @@ -2186,17 +2186,22 @@ _vm_map_clip_start(vm_map_t map, > vm_map_entry_t entry, >         VM_MAP_ASSERT_LOCKED(map); >         KASSERT(entry->end > start && entry->start < start, >             ("_vm_map_clip_start: invalid clip of entry %p", entry)); > +       vm_map_simplify_entry(map, entry); > > > Hi!  > > This isn't just comment.  >   > > >         /* > -        * Split off the front portion -- note that we must insert > the new > -        * entry BEFORE this one, so that this entry has the specified > -        * starting address. > +        * Create a backing object now, if none exists, so that > more individual > +        * objects won't be created after the map entry is split. >          */ > -       vm_map_simplify_entry(map, entry); >         vm_map_entry_charge_object(map, entry); > + > +       /* Clone the entry. */ >         new_entry = vm_map_entry_create(map); >         *new_entry = *entry; > > +       /* > +        * Split off the front portion.  Insert the new entry > BEFORE this one, > +        * so that this entry has the specified starting address. > +        */ >         new_entry->end = start; >         entry->offset += (start - entry->start); >         entry->start = start; > @@ -2244,14 +2249,20 @@ _vm_map_clip_end(vm_map_t map, > vm_map_entry_t entry, v >         KASSERT(entry->start < end && entry->end > end, >             ("_vm_map_clip_end: invalid clip of entry %p", entry)); > > - >         /* > -        * Create a new entry and insert it AFTER the specified entry > +        * Create a backing object now, if none exists, so that > more individual > +        * objects won't be created after the map entry is split. >          */ >         vm_map_entry_charge_object(map, entry); > + > +       /* Clone the entry. */ >         new_entry = vm_map_entry_create(map); >         *new_entry = *entry; > > +       /* > +        * Split off the back portion.  Insert the new entry AFTER > this one, > +        * so that this entry has the specified ending address. > +        */ >         new_entry->start = entry->end = end; >         new_entry->offset += (end - entry->start); >         if (new_entry->cred != NULL) > _______________________________________________ > svn-src-head@freebsd.org  mailing > list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to > "svn-src-head-unsubscribe@freebsd.org > " >