From owner-svn-ports-all@freebsd.org Wed Sep 11 11:04:07 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C6A17F7710; Wed, 11 Sep 2019 11:04:07 +0000 (UTC) (envelope-from koobs@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46SzYM4lM4z3Hs9; Wed, 11 Sep 2019 11:04:07 +0000 (UTC) (envelope-from koobs@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 85BB058D9; Wed, 11 Sep 2019 11:04:07 +0000 (UTC) (envelope-from koobs@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x8BB47Cs081366; Wed, 11 Sep 2019 11:04:07 GMT (envelope-from koobs@FreeBSD.org) Received: (from koobs@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x8BB47OY081365; Wed, 11 Sep 2019 11:04:07 GMT (envelope-from koobs@FreeBSD.org) Message-Id: <201909111104.x8BB47OY081365@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: koobs set sender to koobs@FreeBSD.org using -f From: Kubilay Kocak Date: Wed, 11 Sep 2019 11:04:07 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r511814 - head/www/py-soupsieve X-SVN-Group: ports-head X-SVN-Commit-Author: koobs X-SVN-Commit-Paths: head/www/py-soupsieve X-SVN-Commit-Revision: 511814 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Sep 2019 11:04:07 -0000 Author: koobs Date: Wed Sep 11 11:04:07 2019 New Revision: 511814 URL: https://svnweb.freebsd.org/changeset/ports/511814 Log: www/py-soupsieve: Add missing dependency soupsieve depends on backports.functools_lru_cache [1] on Python versions < 3, add the dependency accordingly. While I'm here: - Add TEST_DEPENDS and test target to improve future QA Note: soupsieve 'requires' [2] beautifulsoup4, but beautifulsoup4 depends on soupsieve via install_requires, causing a technical circular dependency, which is why soupsieve doesn't seem to explicitly install_requires on it ... anymore [3]. This seems bizzare. [1] requirements/project.txt: backports.functools_lru_cache ; python_version < '3' [2] https://github.com/facelessuser/soupsieve#installation [3] https://github.com/facelessuser/soupsieve/commit/9a792216ea1ffce018c7968105540c08b82b96db QA: 624 passed, 2 skipped, 6 warnings in 35.70 seconds PR: 240490 Reported by: jbeich Approved by: portmgr (blanket: missing dependencies, ports compliance) MFH: 2019Q3 (blanket(s): run-time bugfix) Modified: head/www/py-soupsieve/Makefile Modified: head/www/py-soupsieve/Makefile ============================================================================== --- head/www/py-soupsieve/Makefile Wed Sep 11 10:58:32 2019 (r511813) +++ head/www/py-soupsieve/Makefile Wed Sep 11 11:04:07 2019 (r511814) @@ -2,6 +2,7 @@ PORTNAME= soupsieve PORTVERSION= 1.9 +PORTREVISION= 1 CATEGORIES= www python MASTER_SITES= CHEESESHOP PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} @@ -12,8 +13,23 @@ COMMENT= CSS4 selector implementation for BeautifulSou LICENSE= MIT LICENSE_FILE= ${WRKSRC}/LICENSE.md +TEST_DEPENDS= ${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest@${PY_FLAVOR} \ + ${PYTHON_PKGNAMEPREFIX}html5lib>0:www/py-html5lib@${PY_FLAVOR} \ + ${PYTHON_PKGNAMEPREFIX}lxml>0:devel/py-lxml@${PY_FLAVOR} \ + ${PYTHON_PKGNAMEPREFIX}beautifulsoup>4:www/py-beautifulsoup@${PY_FLAVOR} + USES= python USE_PYTHON= autoplist concurrent distutils + NO_ARCH= yes -.include +.include + +.if ${PYTHON_VER} < 3 +RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}backports.functools_lru_cache>0:devel/py-backports.functools_lru_cache@${PY_FLAVOR} +.endif + +do-test: + cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs + +.include