From owner-freebsd-stable@FreeBSD.ORG Tue Apr 21 14:51:07 2009 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17D4B106568B; Tue, 21 Apr 2009 14:51:07 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id DB4358FC08; Tue, 21 Apr 2009 14:51:06 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from [192.168.1.214] (ls-2p2-aw01.ls.eso.org [134.171.80.150]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n3LEp2mM046342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 21 Apr 2009 07:51:04 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <49EDDD51.9040608@freebsd.org> Date: Tue, 21 Apr 2009 10:50:57 -0400 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302) MIME-Version: 1.0 To: Bruce Simpson References: <49E6DB25.2010601@sippysoft.com> <49E6FF8F.4070403@sippysoft.com> <49ED6AD2.4010006@incunabulum.net> In-Reply-To: <49ED6AD2.4010006@incunabulum.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-DCC-x.dcc-servers-Metrics: ebb.errno.com; whitelist Cc: Dennis Melentyev , stable@freebsd.org, "current@freebsd.org" , Maxim Sobolev Subject: Re: kernel compile fails without AH_SUPPORT_AR5416 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 14:51:07 -0000 Bruce Simpson wrote: > Hi, > > Looks like I'm late to the party. I was responsible for committing these > ath(4) changes to RELENG_7. > I can't remember if I tested the kernel compile without the > AH_SUPPORT_AR5416 option or not, I have been so incredibly busy. > > Dennis Melentyev wrote: >> 2009/4/16 Maxim Sobolev : >> >>> Dennis Melentyev wrote: >>> >>>> Could be worth an entry in UPDATING and/or explicitly added to GENERIC. >>>> >>> My point is that if the option is mandatory for compiling ath(4) driver, >>> then there is no point in having this option in the first place. >>> >> >> Well, fair. >> +1 from me :). >> >> > > So is there a consensus that this seems to break the build for folk who > do not need this option? > If so I can see about committing the necessary changes to turn this > option on by default. I needed the option for what I was trying to do. > > Of course if someone already has a patch for that, that will help, as I > don't have a lot of free time at the moment but can certainly commit a > quick fix if someone already has one. ru had a change to fix this but decided not to; can't say why. Otherwise there is a better way to fix this which I alluded to in previous mail--use the config-generated #define that is generated for the "ath_hal" device. As I said I've not had time to look at that won't probably for several weeks. Either way this requirement has been listed in UPDATING ever since the ath hal source code was imported into the tree. Sam