From owner-freebsd-hackers@FreeBSD.ORG Sat Aug 21 08:08:45 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2770E16A4CE for ; Sat, 21 Aug 2004 08:08:45 +0000 (GMT) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DAA443D2D for ; Sat, 21 Aug 2004 08:08:44 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received-SPF: pass (mp2.macomnet.net: domain of maxim@macomnet.ru designates 127.0.0.1 as permitted sender) receiver=mp2.macomnet.net; client_ip=127.0.0.1; envelope-from=maxim@macomnet.ru; Received: from localhost (xuqz761l@localhost [127.0.0.1]) by mp2.macomnet.net (8.12.11/8.12.11) with ESMTP id i7L88eJn034587; Sat, 21 Aug 2004 12:08:40 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Sat, 21 Aug 2004 12:08:40 +0400 (MSD) From: Maxim Konovalov To: Ted Unangst In-Reply-To: <412652AA.5020308@coverity.com> Message-ID: <20040821120624.I34489@mp2.macomnet.net> References: <412652AA.5020308@coverity.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: hackers@freebsd.org Subject: Re: off by one bounds X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2004 08:08:45 -0000 Hi Ted, On Fri, 20 Aug 2004, 12:36-0700, Ted Unangst wrote: > errors in freebsd 4.10 found by Coverity's analysis. [...] > ip_icmp.c:ip_next_mtu, i == sizeof, dir >= 0 This one is not a bug really. If i == sizeof then mtutab[i] == 0 and we return 0 at the line 818. Or I miss something? -- Maxim Konovalov