From owner-cvs-all Sat Sep 15 20:18:22 2001 Delivered-To: cvs-all@freebsd.org Received: from InterJet.elischer.org (c421509-a.pinol1.sfba.home.com [24.7.86.9]) by hub.freebsd.org (Postfix) with ESMTP id 87CB537B401; Sat, 15 Sep 2001 20:18:12 -0700 (PDT) Received: from elischer.org (InterJet.elischer.org [192.168.1.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id UAA08736; Sat, 15 Sep 2001 20:57:38 -0700 (PDT) Message-ID: <3BA4194B.2A4AB339@elischer.org> Date: Sat, 15 Sep 2001 20:15:23 -0700 From: Julian Elischer X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386) X-Accept-Language: en, hu MIME-Version: 1.0 To: obrien@FreeBSD.org Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 References: <20010915121926.A71700@dragon.nuxi.com> <20010916054620.T29957-100000@delplex.bde.org> <20010915165402.A84034@dragon.nuxi.com> Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG David O'Brien wrote: > > On Sun, Sep 16, 2001 at 06:15:45AM +1000, Bruce Evans wrote: > > I now prefer something like: > > > > --- > > > > > > #if 0 /* maybe change to #ifdef VENDOR_ID */ > > > > #endif > > > > #include > > __FBSDID($NetBSD$) > > --- can someone explain to me what on earth all this is about? don't "get" what all this__FBSDID() stuff is trying to achieve.. > > Why do we need to "#if 0" out NetBSD's __RCSID's? Our macros handle them > just fine. Thus we would only be adding __FBSDID() to such code. > Is it OK to only comment out non-__RCSID using code? Doing it your way, > adds more of our changes around possible Vendor code -- CVS will barf > harder in the face of that. > > -- > -- David (obrien@FreeBSD.org) -- +------------------------------------+ ______ _ __ | __--_|\ Julian Elischer | \ U \/ / hard at work in | / \ julian@elischer.org +------>x USA \ a very strange | ( OZ ) \___ ___ | country ! +- X_.---._/ presently in San Francisco \_/ \\ v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message