From owner-svn-ports-all@freebsd.org Wed Oct 24 14:01:16 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DAA0EFE95A8; Wed, 24 Oct 2018 14:01:15 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 617ED91753; Wed, 24 Oct 2018 14:01:15 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A6340220BA; Wed, 24 Oct 2018 10:01:09 -0400 (EDT) Received: from web3 ([10.202.2.213]) by compute4.internal (MEProxy); Wed, 24 Oct 2018 10:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=TvKaWqPX5bm1Jf72FcN80ajmPgUpNDNIYsSzp9g6O e0=; b=KA6TMFtQWfh3aCV2wAQvHGWLXz9VUqyVW5z0EuKyLEkArmercez1I8QKu Z4hTEvrVbmkP3fYB5uFKrZ46UPRFIXShZ5pkBSotcre/fyuP0gceIG1OhGvALfB+ kiFpa+lu59/yGaew6igDWC+mip8nVpfHotstaSwM4WCmlBrslJC2Wzqos/InI8fi p7kCxOl43pMoTJyVdQ6pyd6MONDfiGKkn5ZRAPs3ysSIsyBif5JrvrMJeNdw1lrZ 5pxkFq/HrF2bYEvcPzbrJO5W0jCE0B8sUW8UIU/2s2GER7yN6tmWt5/JWMHYTCBA 6SExGjOoYGQ2kPotjwqlSrWYwNUcA== X-ME-Sender: X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 3D8E09E4ED; Wed, 24 Oct 2018 10:01:08 -0400 (EDT) Message-Id: <1540389667.2440303.1553046944.02AD235E@webmail.messagingengine.com> From: Tobias Kortkamp To: Wen Heping , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-b315a288 In-Reply-To: <201810240800.w9O80Zne001062@repo.freebsd.org> References: <201810240800.w9O80Zne001062@repo.freebsd.org> Subject: Re: svn commit: r482889 - head/editors/ne Date: Wed, 24 Oct 2018 16:01:07 +0200 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 14:01:16 -0000 On Wed, Oct 24, 2018, at 10:00, Wen Heping wrote: > Author: wen > Date: Wed Oct 24 08:00:34 2018 > New Revision: 482889 > URL: https://svnweb.freebsd.org/changeset/ports/482889 > > Log: > - Update to 3.1.2 > > PR: 232338 > Submitted by: ndowens@yahoo.com > > Modified: > head/editors/ne/Makefile > head/editors/ne/distinfo > > Modified: head/editors/ne/Makefile > ============================================================================== > --- head/editors/ne/Makefile Wed Oct 24 07:17:16 2018 (r482888) > +++ head/editors/ne/Makefile Wed Oct 24 08:00:34 2018 (r482889) > @@ -2,7 +2,7 @@ > # $FreeBSD$ > > PORTNAME= ne > -PORTVERSION= 3.1.1 > +PORTVERSION= 3.1.2 > CATEGORIES= editors > MASTER_SITES= http://ne.di.unimi.it/ > > @@ -12,11 +12,10 @@ COMMENT= Nice and powerful editor > LICENSE= GPLv3 > LICENSE_FILE= ${WRKSRC}/COPYING > > -BUILD_WRKSRC= ${WRKSRC}/src > - > USES= gmake makeinfo perl5 > USE_PERL5= build > USE_CSTD= c99 > + > MAKEFILE= makefile > MAKE_ARGS= CC="${CC}" \ > OPTS="${CFLAGS}" \ > @@ -24,12 +23,12 @@ MAKE_ARGS= CC="${CC}" \ > NE_GLOBAL_DIR="${DATADIR}" > ALL_TARGET= ne > > -LDFLAGS+= -lgnuregex > +LDFLAGS= -lgnuregex I think that this should be kept as LDFLAGS+=, so that user settings in make.conf are not completely ignored by the port. > > +BUILD_WRKSRC= ${WRKSRC}/src > INFO= ne > -PORTDOCS= * > -PORTDATA= * > -PLIST_FILES= bin/ne man/man1/ne.1.gz > +DOCS= CHANGES NEWS README.md doc/default.* \ > + doc/ne.pdf doc/ne.txt doc/html/* > > OPTIONS_DEFINE= DEBUG DOCS > > @@ -40,33 +39,15 @@ post-patch: > 's|"regex\.h"||g' > @${REINPLACE_CMD} -e \ > 's|-O3|| ; \ > - /[[:space:]]regex.o/d ; \ > + /[[:space:]]regex.o/d ; \ > s|regex.h$$||g' ${BUILD_WRKSRC}/makefile > + @${REINPLACE_CMD} -e '/cp -pR/d' ${WRKSRC}/makefile > > -post-build: > - cd ${WRKSRC}/doc && makeinfo ne.texinfo > +post-install: > + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/ne > > -do-install: > - (cd ${BUILD_WRKSRC} && ${INSTALL_PROGRAM} ne \ > - ${STAGEDIR}${PREFIX}/bin) > - (cd ${WRKSRC}/doc && ${INSTALL_MAN} ne.1 \ > - ${STAGEDIR}${MANPREFIX}/man/man1) > - (cd ${WRKSRC}/doc && ${INSTALL_DATA} ne.info \ > - ${STAGEDIR}${PREFIX}/${INFO_PATH}) > - @${MKDIR} ${STAGEDIR}${DATADIR}/macros > - (cd ${WRKSRC}/macros && ${INSTALL_DATA} * \ > - ${STAGEDIR}${DATADIR}/macros) > - @${MKDIR} ${STAGEDIR}${DATADIR}/syntax > - (cd ${WRKSRC}/syntax && ${INSTALL_DATA} *.jsf \ > - ${STAGEDIR}${DATADIR}/syntax) > - > do-install-DOCS-on: > @${MKDIR} ${STAGEDIR}${DOCSDIR} > - (cd ${WRKSRC} && ${INSTALL_DATA} CHANGES NEWS README.md \ > - ${STAGEDIR}${DOCSDIR}) > - (cd ${WRKSRC}/doc && ${INSTALL_DATA} default.* ne.pdf ne.txt \ > - ${STAGEDIR}${DOCSDIR}) > - @(cd ${WRKSRC}/doc && ${COPYTREE_SHARE} html \ > - ${STAGEDIR}${DOCSDIR}) > + ${INSTALL_DATA} ${DOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR} > > .include Did you forget to svn add a pkg-plist? PORTDOCS, PORTDATA, and PLIST_FILES are all gone now, so there probably should be one if this port is supposed to do something. Right now the build succeeds (if not in port testing mode) but the package is empty.