From owner-svn-src-all@freebsd.org Sat Jun 25 18:25:52 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E70A3B81CDB; Sat, 25 Jun 2016 18:25:52 +0000 (UTC) (envelope-from fidaj@ukr.net) Received: from frv157.fwdcdn.com (frv157.fwdcdn.com [212.42.77.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9B6032526; Sat, 25 Jun 2016 18:25:51 +0000 (UTC) (envelope-from fidaj@ukr.net) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ukr.net; s=fsm; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=RcAXX/GOINFltmJUZNIh5aCeeJPDxSafm2nVRNzdl/c=; b=M4bqp3WUinoyCfKxVKdrotfaH0yAez7enNo1mLN6P0K/9k+vvRpD4aSzaPz4JrEvpQu1ZbF//voYh1Zodw5SIX851jDmjK4GlUICZIAHuaduHGIY9/bPJIyEe9kugmOKfYYnvNi07Ub3JDVFhmgdv4lpbobsm4D12OdgN9v6eN0=; Received: from [37.229.193.176] (helo=nonamehost.local) by frv157.fwdcdn.com with esmtpsa ID 1bGsH7-0004Pc-7T ; Sat, 25 Jun 2016 21:25:49 +0300 Date: Sat, 25 Jun 2016 21:25:48 +0300 From: Ivan Klymenko To: Konstantin Belousov Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r302194 - head/lib/libthr/thread Message-ID: <20160625212548.14057aa1@nonamehost.local> In-Reply-To: <20160625180657.GG38613@kib.kiev.ua> References: <20160625170406.77c79b2e@nonamehost.local> <20160625140529.GW38613@kib.kiev.ua> <20160625171800.50a43746@nonamehost.local> <20160625142915.GX38613@kib.kiev.ua> <20160625175503.7c57d42b@nonamehost.local> <20160625152006.GA38613@kib.kiev.ua> <20160625190346.19a1ef0d@nonamehost.local> <20160625161615.GD38613@kib.kiev.ua> <20160625204317.0aae5c98@nonamehost.local> <20160625180543.GF38613@kib.kiev.ua> <20160625180657.GG38613@kib.kiev.ua> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Authentication-Result: IP=37.229.193.176; mail.from=fidaj@ukr.net; dkim=pass; header.d=ukr.net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2016 18:25:53 -0000 On Sat, 25 Jun 2016 21:06:57 +0300 Konstantin Belousov wrote: > On Sat, Jun 25, 2016 at 09:05:43PM +0300, Konstantin Belousov wrote: > > On Sat, Jun 25, 2016 at 08:43:17PM +0300, Ivan Klymenko wrote: =20 > > > ./thr_mutex_test > > > thr_mutex_test: mutex_trylock 2: No error: 0 =20 > >=20 > > Ok, there is a bug in my test, it must use errc(3) and not err(3). > > Please retest wth the updated code below. But I am sure that you > > would see EDEADLK (Resource deadlock avoided) error, which means > > that you have wrong, i.e. unpatched libthr, installed. > >=20 > > For me, the output is=20 > > sandy% ./pthread_errrecurse > > sandy% echo $? > > 0 > > =20 > Err, the updated test. >=20 > /* $Id: pthread_errrecurse.c,v 1.2 2016/06/25 18:02:54 kostik Exp > kostik $ */ >=20 > #include > #include > #include >=20 > int > main(void) > { > pthread_mutex_t m; > pthread_mutexattr_t ma; > int error; >=20 > error =3D pthread_mutexattr_init(&ma); > if (error !=3D 0) > errc(1, error, "mutexattr_init"); > error =3D pthread_mutexattr_settype(&ma, > PTHREAD_MUTEX_ADAPTIVE_NP); if (error !=3D 0) > errc(1, error, "mutexattr_settype"); > error =3D pthread_mutex_init(&m, &ma); > if (error !=3D 0) > errc(1, error, "mutex_init"); > error =3D pthread_mutex_trylock(&m); > if (error !=3D 0) > errc(1, error, "mutex_trylock 1"); > error =3D pthread_mutex_trylock(&m); > if (error !=3D EBUSY) > errc(1, error, "mutex_trylock 2"); > else if (error =3D=3D 0) > errx(1, "mutex_trylock 2 succeeded"); > return (0); > } 1. Patched & installed libthr r302195 2. test for other soft: mousepad=20 GLib (gthread-posix.c): Unexpected error from C library during 'pthread_mutex_trylock': =D0=A3=D0=BD=D0=B8=D0=BA=D0=BD=D1=83=D1=82=D0=BE = =D0=B2=D0=B7=D0=B0=D1=94=D0=BC=D0=BD=D0=B5 =D0=B1=D0=BB=D0=BE=D0=BA=D1=83= =D0=B2=D0=B0=D0=BD=D0=BD=D1=8F =D1=80=D0=B5=D1=81=D1=83=D1=80=D1=81=D1=96= =D0=B2. Aborting. =D0=90=D0=B2=D0=B0=D1=80=D1=96=D0=B9=D0=BD=D0=B5 =D0=B7=D0=B0=D0= =B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D1=8F(=D0=B7=D0=B0=D0=BF=D0=B8=D1= =81=D0=B0=D0=BD=D0=BE core) 3.test new ./thr_mutex_test=20 thr_mutex_test: mutex_trylock 2: No error: 0 4. restore patch & install original libthr r302195 5. test for other soft: mousepad GLib (gthread-posix.c): Unexpected error from C library during 'pthread_mutex_trylock': =D0=A3=D0=BD=D0=B8=D0=BA=D0=BD=D1=83=D1=82=D0=BE = =D0=B2=D0=B7=D0=B0=D1=94=D0=BC=D0=BD=D0=B5 =D0=B1=D0=BB=D0=BE=D0=BA=D1=83= =D0=B2=D0=B0=D0=BD=D0=BD=D1=8F =D1=80=D0=B5=D1=81=D1=83=D1=80=D1=81=D1=96= =D0=B2. Aborting. =D0=90=D0=B2=D0=B0=D1=80=D1=96=D0=B9=D0=BD=D0=B5 =D0=B7=D0=B0=D0= =B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D1=8F(=D0=B7=D0=B0=D0=BF=D0=B8=D1= =81=D0=B0=D0=BD=D0=BE core) 6. test new ./thr_mutex_test=20 thr_mutex_test: mutex_trylock 2: No error: 0 7. restore & install libthr r302191 8. test for other soft: mousepad - complete run 9. test new ./thr_mutex_test=20 thr_mutex_test: mutex_trylock 2: No error: 0