From owner-freebsd-ports Fri Feb 22 11:48:39 2002 Delivered-To: freebsd-ports@freebsd.org Received: from alcatraz.iptelecom.net.ua (alcatraz.iptelecom.net.ua [212.9.224.15]) by hub.freebsd.org (Postfix) with ESMTP id 8D87337B404; Fri, 22 Feb 2002 11:48:24 -0800 (PST) Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by alcatraz.iptelecom.net.ua (8.9.3/8.9.3) with ESMTP id VAA08292; Fri, 22 Feb 2002 21:48:09 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: from vega.vega.com (h65.227.dialup.iptcom.net [212.9.227.65]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id VAA47909; Fri, 22 Feb 2002 21:48:03 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.6/8.11.3) with ESMTP id g1MJZMs12952; Fri, 22 Feb 2002 21:35:22 +0200 (EET) (envelope-from sobomax@FreeBSD.org) Message-ID: <3C769D92.7C1C441F@FreeBSD.org> Date: Fri, 22 Feb 2002 21:35:46 +0200 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: Will Andrews Cc: Mario Sergio Fujikawa Ferreira , portmgr@FreeBSD.org, FreeBSD-ports@FreeBSD.org Subject: Re: bsd.port.mk MASTER_SITES_NN misbehavior (was ghostscript-afpt and MASTER_SITES_NN patch) References: <20020221221039.19324.qmail@exxodus.fedaykin.here> <3C764483.F20F486C@FreeBSD.org> <20020222144830.GS82673@squall.waterspout.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Will Andrews wrote: > > On Fri, Feb 22, 2002 at 03:15:47PM +0200, Maxim Sobolev wrote: > > > The MASTER_FILTER_PERL idea was discussed with Anton Berezin > > > (project tobez :). After constructing any variables, we use it to > > > remove ANY repeated instances since repetition means bogus instance. > > > It is a neat thing, not only it "hides" the MASTER_SITES_NN problem > > > but also add a level of protection against poorly written MASTER_SITES. > > > Let me know what do you think. > > > > I object. This is a bad practice to use a workaroung to fix misdesign > > instead of fixing the real source of the problem. Please fix > > MASTER_SITES_NN properly. > > What exactly is a "bad practice"? Bad practice is using a workaround to fix the problem instead of fixing underlying algorithm. > What's "misdesigned"? Misdesign here is that MASTER_SITES_NN lists some sites several times. > What's > the "real source of the problem"? Donno, because I'm not the author of the feature in question. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message