From nobody Wed Oct 29 11:17:22 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cxPpq0xXhz6DXp2; Wed, 29 Oct 2025 11:17:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cxPpp6YdYz47j8; Wed, 29 Oct 2025 11:17:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761736642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K9IK2zRNjIhfGNhUUoJdSTT3YWCAMv9bs6VmQNvqk5Y=; b=hpbpz2YHAA5EZlJfSOd5QXyIOM4f+yAsccEZZnDfyvacjcael9r7ePyEDbsDEsFKUwLf50 3tyQSDWu95wemBv8ovKLOg3eejEtjI9lLWJnlSploj3Zr+fwZEVReaBrrhF89sDOs9bOgE bFWPqdyQB8TOWUsBgjiyf3RG+bDhSA6tqotvxWGQ1grqltCFFE6bhw4c48U4ikjLGjR7E4 MO0xtKre5SM1t0EOagVqoBUYsOMVfF5VLtuZsR8QMtiQj08XWKcxG9s+lJkyhFv8O3Ele3 ahYnBlcr+vWpjRUg82CUrv+dllmiO/2UPOq96yOkxvzMa7LcAPbRM74wcwsAdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761736642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K9IK2zRNjIhfGNhUUoJdSTT3YWCAMv9bs6VmQNvqk5Y=; b=iP4T0GZtgD9LN16Ub4Ct1aYjaXsBeoY/Dfv5mgUj0ppLqLmIgTZEcJae8+9V/3szK9Q3cL inO7eExG5QnyODyaI72NXYOXyY9NHxQkUpmAV5Ku23VyHx3JC68z0C6NPEPIwbpqH90xjf Vgh2KOjAkZ+N03TI9ce2yZ++sxDecjGR3ljmsGp++IRbnNDtk/aA+EQn/5AT4Povgv8YkO qWQ+VfSyFfeaCRhBfNmxqIvC2wn4386oQz8GWPCeaUa0+wfB17Z9/KV3JhbWkm9QL5emY8 yycc32HjE74UYnujWP4K9JTXSkWR47hBzz/gOZSQnVapDE2TG1dRZFoMaoAESg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761736642; a=rsa-sha256; cv=none; b=vrpIr1KDAEW2JbwnqfPBjGs+tr1iZR/Djp3ZW4vEZneRCLovkWmhWTdsJxI/T3TD4eow1W 8PgZ4KpcPn2mZFpgbKAGbHClzUf0yC1fDjelhBOKFuf4JsHnLViVHOcLcfOwEyUfoycT+9 EW7XaQ89gohUetKlIP8hUtFriiFv2gfRDc+DcA1gfEaYNPxhkl5QMBRTmV6cA7l3us+z03 I6W102Q9aLvFxtmbxAcKY/L5Af+wKgSKXH2MQbXr8BuZixv8l5JlYZLjTJUD41JtBj7vTb MGxDMLjkqui2Qwnwxd+zDo6R2VAC8tjp6Y+Zdn14WrrxRNCMVaQkEPIzIW7F3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cxPpp5vBLzZnc; Wed, 29 Oct 2025 11:17:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59TBHMqp042583; Wed, 29 Oct 2025 11:17:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59TBHMme042580; Wed, 29 Oct 2025 11:17:22 GMT (envelope-from git) Date: Wed, 29 Oct 2025 11:17:22 GMT Message-Id: <202510291117.59TBHMme042580@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Robert Clausecker Subject: git: cb2921924549 - stable/14 - sys/arm64: fix COMPAT_FREEBSD32 __syscall() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: fuz X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: cb2921924549b8068c67c6e35331d72b9b71e658 Auto-Submitted: auto-generated The branch stable/14 has been updated by fuz: URL: https://cgit.FreeBSD.org/src/commit/?id=cb2921924549b8068c67c6e35331d72b9b71e658 commit cb2921924549b8068c67c6e35331d72b9b71e658 Author: Robert Clausecker AuthorDate: 2025-10-21 21:35:24 +0000 Commit: Robert Clausecker CommitDate: 2025-10-29 11:16:47 +0000 sys/arm64: fix COMPAT_FREEBSD32 __syscall() It seems like _QUAD_LOWWORD was incorrectly expanded into 1, which is correct for big endian but not little endian. This means we always grab the padding word for the syscall number, which is usually 0, causing SIGSYS to be delivered to the caller. Reintroduce _QUAD_LOWWORD to fix the syscall. PR: 290411 MFC after: 1 week Discussed with: jrtc27 Reviewed by: cognet, emaste Approved by: markj (mentor) Fixes: 8c9c3144ccfa3061879b8cec015ee7d1010e4766 Differential Revision: https://reviews.freebsd.org/D53250 (cherry picked from commit 1ca09538d94273601dac08204c1d0b3ca9115864) --- sys/arm64/arm64/elf32_machdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/arm64/arm64/elf32_machdep.c b/sys/arm64/arm64/elf32_machdep.c index 5f35d01f9ac0..285be3d89cbb 100644 --- a/sys/arm64/arm64/elf32_machdep.c +++ b/sys/arm64/arm64/elf32_machdep.c @@ -208,7 +208,7 @@ freebsd32_fetch_syscall_args(struct thread *td) sa->code = *ap++; nap--; } else if (sa->code == SYS___syscall) { - sa->code = ap[1]; + sa->code = ap[_QUAD_LOWWORD]; nap -= 2; ap += 2; }