From owner-freebsd-ruby@freebsd.org Mon Aug 10 11:04:32 2015 Return-Path: Delivered-To: freebsd-ruby@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8570699E5FB for ; Mon, 10 Aug 2015 11:04:32 +0000 (UTC) (envelope-from info@toco-domains.de) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6CAE71E1E for ; Mon, 10 Aug 2015 11:04:32 +0000 (UTC) (envelope-from info@toco-domains.de) Received: by mailman.ysv.freebsd.org (Postfix) id 6C15599E5F9; Mon, 10 Aug 2015 11:04:32 +0000 (UTC) Delivered-To: ruby@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BAE699E5F6 for ; Mon, 10 Aug 2015 11:04:32 +0000 (UTC) (envelope-from info@toco-domains.de) Received: from toco-domains.de (mail.toco-domains.de [176.9.39.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2F9C41E1D; Mon, 10 Aug 2015 11:04:31 +0000 (UTC) (envelope-from info@toco-domains.de) Received: from [0.0.0.0] (mail.toco-domains.de [176.9.39.170]) by toco-domains.de (Postfix) with ESMTPA id 610D11B2285B; Mon, 10 Aug 2015 13:04:23 +0200 (CEST) Subject: Re: [Gitlab] Current Status of the port To: Steve Wills References: <20150804133657.GA52831@mouf.net> <55C0CAB5.9050003@toco-domains.de> <20150805000444.GA56001@mouf.net> <55C22577.6040802@toco-domains.de> <20150805152100.GA86368@mouf.net> <20150805163509.GB86368@mouf.net> <20150805171038.GC86368@mouf.net> <55C374B2.9030808@toco-domains.de> <20150806151608.GA11353@mouf.net> <55C37D2D.9050302@toco-domains.de> <20150806155233.GC11353@mouf.net> Cc: ruby@freebsd.org From: Torsten Zuehlsdorff Message-ID: <55C88531.1070007@toco-domains.de> Date: Mon, 10 Aug 2015 13:04:17 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150806155233.GC11353@mouf.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ruby@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Ruby discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2015 11:04:32 -0000 Hello, >>>>>>>> I will have a look at it. Is there anything in "Admin Area" -> "Logs" >>>>>>>> which could be helpful? >>>>>>> >>>>>>> No, it looks to be a javascript issue, clicking the button doesn't even trigger >>>>>>> any sort of http request, it just does nothing. >>>>>> >>>>>> I think I may have figured out the issue. jquery 4.x isn't compatible with >>>>>> rails 4.1, it needs 4.2: >>>>>> >>>>>> https://github.com/rails/jquery-rails/blob/master/CHANGELOG.md >>>>>> >>>>>> So we need jqueyr 3.1.3 and friends. I'll have a look at changing that locally to test. >>>>> >>>>> Looks like cal-heatmap-rails upgrade from 0.0.1 to 3.5.1 was the real issue. >>>>> Tho I think we may want to consider dropping jquery-rails back to 3.1.3 just to >>>>> be safe and what I said about changing ~> to => in Gemfile still applies. >>>> >>>> Okay, i will create a port for the old jquery-rails. Currently there is >>>> a pending slave-port "rubygem-jquery-rails41" for GitLab. I could >>>> rewrite it to use 3.1.3. Or should i replace it with an explicit >>>> "rubygem-jquery*3*-rails41"? In this case we can omit the other one. >>> >>> Either way is fine. >> >> In this case i will create "rubygem-jquery*3*-rails41". This avoid an >> "unwanted" update to the actual version. > > Sounds good, you'll want to put a PORTSCOUT line in there too. In my "big patch with GitLab" there was already a port "rubygem-jquery-rails-railties41" which has the jquery-rails 3 dependency within. (But there is an error in its dependency definition) After some confusion about the package names, should this new port named "rubygem-jquery-rails-railties41" or "rubygem-jquery-rails-rails41". It seems that when ports defines a dependency to railties there name is suffixed with "-rails". I suffixed them with "-railties" because for my novice sense, this was not the same. ;) But to stay coherent i should use "-rails41" as suffix - am i right? Next question: what should i do with the number of slave ports? Should i create a PR with a big patch including GitLab? Or should i open PRs for the slave ports and GitLab itself? I saw that you committed many of the PRs. Thank you very much for your work! Greetings, Torsten