From owner-svn-src-all@freebsd.org Wed Jan 13 10:50:02 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CECDDA80C88; Wed, 13 Jan 2016 10:50:02 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 930471F91; Wed, 13 Jan 2016 10:50:02 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 9028B25D387C; Wed, 13 Jan 2016 10:49:58 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id E8E5EC77050; Wed, 13 Jan 2016 10:49:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id cp53-C94JyNc; Wed, 13 Jan 2016 10:49:56 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 7625DC76FD1; Wed, 13 Jan 2016 10:49:55 +0000 (UTC) Date: Wed, 13 Jan 2016 10:49:55 +0000 (UTC) From: "Bjoern A. Zeeb" To: Sepherosa Ziehau cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r293719 - head/sys/dev/hyperv/netvsc In-Reply-To: <201601120130.u0C1UpvA074721@repo.freebsd.org> Message-ID: References: <201601120130.u0C1UpvA074721@repo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 10:50:02 -0000 On Tue, 12 Jan 2016, Sepherosa Ziehau wrote: > Author: sephe > Date: Tue Jan 12 01:30:51 2016 > New Revision: 293719 > URL: https://svnweb.freebsd.org/changeset/base/293719 > > Log: > hyperv/hn: Implement LRO > > - Implement the LRO using tcp_lro APIs, and LRO is enabled by default. Which are only available if INET or INET6 are compiled into the kernel. Unfortunately this breaks kernel builds that do not include IPv4 or IPv6 support. Can you please put appropriate #if defined(INET6) || defined(INET) in place? > Differential Revision: https://reviews.freebsd.org/D4824 > > Modified: > head/sys/dev/hyperv/netvsc/hv_net_vsc.c > head/sys/dev/hyperv/netvsc/hv_net_vsc.h > head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c hv_netvsc_drv_freebsd.o: In function `netvsc_recv': /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x483): undefined reference to `tcp_lro_rx' hv_netvsc_drv_freebsd.o: In function `netvsc_recv_rollup': /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x5ce): undefined reference to `tcp_lro_flush' hv_netvsc_drv_freebsd.o: In function `netvsc_attach': /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0x901): undefined reference to `tcp_lro_init' hv_netvsc_drv_freebsd.o: In function `netvsc_detach': /scratch/tmp/bz/head.svn/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:(.text+0xca8): undefined reference to `tcp_lro_free' --- kernel --- *** [kernel] Error code 1 bmake: stopped in /storage/head/obj/scratch/tmp/bz/head.svn/sys/LINT-NOIP > head/sys/dev/hyperv/netvsc/hv_rndis.h > head/sys/dev/hyperv/netvsc/hv_rndis_filter.c > head/sys/dev/hyperv/netvsc/hv_rndis_filter.h