From owner-svn-src-all@freebsd.org Fri Aug 30 22:09:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 028CBDA237 for ; Fri, 30 Aug 2019 22:09:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46KttH4Dyxz4cyb for ; Fri, 30 Aug 2019 22:09:11 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1567202949; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=BDnzhzE0LkDTjnsUmL9zcDpb/Tsk/FQgEIvQ1WPCgLpRi8bOXsttT9gIlXiBYK0B+XGmaQJlvpGkx 04KAdPiV577aIIzmO2CLcoZSV+71PTpBl9wMlVvHs4AqEj1IlUTb92KQ+zTfLHedC+L0H8d+k82HqW 5u69E6tus7RY/HZYsksZX8bHtayQVwIDw6+v/iyv0IyuO4B1GVa8g0CQ7JSHIGrFb3wsgWIbBwBWT9 W6PN5t6EGxf2RfZuOdzUydRL4C1Rsm40imMCXqSIXrx3sSVboEetObVycAJLwvERJKuOi2F1n3z27y xee5kPN9F6c69/bzWmwnR2z26xj+2Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=Y2vNdoT36ll9dWXbUeng8xFhar5CS2TAf83tj3AUalM=; b=gOaVBI0Rz1AaNz48KB0D9B6WTGpVSgxcMCSf2mGwc1L1id1HhR+6VGWM6lCI0Pn3TOjc5CzaVtYLO HDzxLiunBi6eqNT5T3gKeu2aE3YFjqlElSVMV4c9TSXNaNILg306Qy3//JfaRf+TiDlQEuilv7ce+6 8Lok6BCD1PvJHdlrUpMn7e9Ea2lWihZSPM2Jf9uMRFF+f82MHLI0U2r6bhp2RyO+JjCY5EPVjjOVdT 8/R1y0tMM+WJOqDarbTxXDMNO4nCmAD5z0Dp6X+EOPvu6jKs3pU7F9/dCQED7PKQGeyhXO03xg2xMI 2VMgjSMrVbCJuKUoZ0Wd2cdp8P1yfkg== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=Y2vNdoT36ll9dWXbUeng8xFhar5CS2TAf83tj3AUalM=; b=so5Ac+XmcIpus9PacZnDPeHR0BOpLZdqb453R5PRaY5NnJj2qsTz50laofCbWtiNu0xXAcB9NASVy qLLj09lR37uqqs24XKONtElFZaNL1xdxCQoaxdhv3NvPwsf+kdjVtjo9ZSCuadzPKnmxtXQQKzYqUg 82MZ40tXfQF1ana7byNgMq1GruXIw9n+EPmR6fR0a7X4yfM0LpR7tNf/BD3k2xgvBvArZ1Bzv2R2Vl bjWs5VtInldb086+INKf2TeOn9bgVNiGCSDVDuDI9QHUZbJbixQ2qJIv/examb/S7NGe2fnfNLQr/Z Q0uygIm8pE5WQab6jBVRfLANZB+M9iQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: c8e7425b-cb72-11e9-85ed-13b9aae3a1d2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id c8e7425b-cb72-11e9-85ed-13b9aae3a1d2; Fri, 30 Aug 2019 22:09:08 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7UM96rB022648; Fri, 30 Aug 2019 16:09:06 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <6035df87490ebb7429f76d57a3a5d33e86c06b56.camel@freebsd.org> Subject: Re: svn commit: r351471 - in head/sys: kern sys From: Ian Lepore To: Mateusz Guzik , Oliver Pinter Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Date: Fri, 30 Aug 2019 16:09:06 -0600 In-Reply-To: References: <201908250511.x7P5BiPl016074@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46KttH4Dyxz4cyb X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Aug 2019 22:09:12 -0000 On Sat, 2019-08-31 at 00:03 +0200, Mateusz Guzik wrote: > On 8/25/19, Oliver Pinter wrote: > > On Sunday, August 25, 2019, Mateusz Guzik wrote: > > > > > Author: mjg > > > Date: Sun Aug 25 05:11:43 2019 > > > New Revision: 351471 > > > URL: https://svnweb.freebsd.org/changeset/base/351471 > > > > > > Log: > > > vfs: add vholdnz (for already held vnodes) > > > > > > Why? > > > > (Yes, is can read the real reason in phabricator, but the > > phabricator > > didn't considered a persistent information in relation to commit > > message. > > Review helper tool just comes and goes as time goes forward, but > > commit > > messages survives the repo conversions to other VCS...) > > > > And once you have taken the time to write a correct description in > > phabricator, it would be really really nice and helpful if you > > would copy > > them into commit message. > > > > I think it's a fair point that if I included this info in the review > it > should make it's way into the commit message. > When I open a new phab review, I specifically write the one-line summary and text that follows with the idea that I'm going to cut and paste that exact text as the commit message (mostly because it's easier to just write all that stuff once). If there are things I want to say there that don't make sense for the commit I typically add them as a separate comment right after I open the initial review. -- Ian