From owner-svn-src-head@FreeBSD.ORG Thu Jan 22 10:06:27 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 719F86EA; Thu, 22 Jan 2015 10:06:27 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 26F6E9BF; Thu, 22 Jan 2015 10:06:26 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id D40011FE023; Thu, 22 Jan 2015 11:06:23 +0100 (CET) Message-ID: <54C0CBD2.9020206@selasky.org> Date: Thu, 22 Jan 2015 11:07:14 +0100 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "K. Macy" Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54BDD9E1.6090505@selasky.org> <20150120075126.GA42409@kib.kiev.ua> <54BE0AAA.4050104@selasky.org> <20150120090057.GD42409@kib.kiev.ua> <54BE21F0.6010602@selasky.org> <7C692107-51CF-4DFA-BD6C-623D56893150@bsdimp.com> <54C0A352.8090701@selasky.org> <20150122081023.GT42409@kib.kiev.ua> <54C0B75B.9070305@selasky.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Konstantin Belousov , Warner Losh X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 10:06:27 -0000 On 01/22/15 10:49, K. Macy wrote: >>> Sigh, you still do not understand. It is your duty to identify all pieces >>> which break after your change. After that, we can argue whether each of >>> them is critical or not to allow the migration. But this must have been >>> done before the KPI change hit the tree. >>> >> >> Hi, >> >> Are you saying that pieces of code that runs completely unlocked using >> "volatile" as only synchronization mechanism is better than what I would >> call a temporary and hopefully short TCP stack performance loss? >> > > > Hans - The project has long standing expectations about how changes > are made to core subsystems. When you hear "understand" your ego > intercedes - put that aside. I told you this first this afternoon and > others have repeated it several times. When you change a KPI, > consumers are updated at the same time - _period_. This protocol is > not up for debate. I'm glad that others have the presence of mind and > fortitude to insist on this. Your work is appreciated, but whether or > not you agree about this is not relevant. > > We're all sorry if this upsets you but this is only a temporary > setback. Channelling this work through phabricator will go a long way > towards smoothing over the current friction. Think about the greater > goal here, not whether this is "done" now or in a week. > Hi Kip, That is fine by me. I didn't know about the "protocol" you refer to until now. I will revert my callout patch and hopefully without causing any build issues and then we can have another round in the Phabricator to iron out the TCP stack issues and possibly others. Sounds good. Please give me some hours to ensure that the pullout doesn't cause any build breakages. Thank you! --HPS