Date: Thu, 27 Sep 2001 13:56:23 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: audit@FreeBSD.ORG Cc: David Hill <david@phobia.ms> Subject: Re: strlcpy patches Message-ID: <p05101009b7d911af53c3@[128.113.24.47]> In-Reply-To: <p05101017b780e3a525c6@[128.113.24.47]> References: <20010718145258.1d829df6.david@phobia.ms> <p05101017b780e3a525c6@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
People with good memories might remember that back
on July 22/2001, I (Garance A Drosihn) wrote:
>At 2:52 PM -0400 7/18/01, David Hill wrote:
>>Greetings.
>>I have patched some source files replacing:
>>
>> strncpy(dst, src, sizeof(dst) - 1);
>> dst[sizeof(dst)-1] = '\0';
>>with
>> strlcpy(dst, src, sizeof dst);
>>
>>They are located at http://www.phobia.ms/patches
>
>I have committed changes with similar intent to current for the
>files under usr.sbin/lpr, and will MFC them next weekend. I
>then intend to do almost no work in freebsd for the month of
>August (partially due to 4.4, and partially because I'll be too
>busy here at work). If no one else has picked up your strlcpy
>changes by the time I get back to making changes, I'll see about
>applying these patches to other source files.
Well, it looks like I'm finally getting to a "less busy" time, so
I'm going to go thru these and commit them. I intend to break up
the commits into "a program's worth at a time", instead of doing
them all in one big massive commit. Should I post each of those
here for a second review, or just go ahead and make the commits
to -current?
[it'll probably be a week or so before the commits start showing up,
as I want to run with the changes for a little while before commits]
--
Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu
Senior Systems Programmer or gad@freebsd.org
Rensselaer Polytechnic Institute or drosih@rpi.edu
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p05101009b7d911af53c3>