From nobody Fri Feb 3 16:08:11 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P7gYV2dptz3kTKW; Fri, 3 Feb 2023 16:08:14 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P7gYV2Bclz3mnW; Fri, 3 Feb 2023 16:08:14 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675440494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUXphYDMEjjOy/RkTJz/AoqLtbS6znact/XPaEgzTtg=; b=kMU/dzu8hrG/P+YOEmgP0yDLiEvGbPWMqFCuXZLaYsetRohq511fBzi/5GhL0Yo/MYffXt Mw+e2iT/Efex/yrLqW4kyNK25HTe5KTVbADvzrcBki1t4knvhstQ6ttF8gvWzQL9ePu8ti BRaivNF5NO+17qJnt5/97feAK1ji8G2DjM/UYdRjub48KQJY4UaDsYNmV6VWjmuHJtm7HL PcZVYIEnWbGVyd23TSsEMKJ07HHbkJ3ehQZ55y6Vxhsy4ygZkGdDNE2X0ryQnx+L6DTsUW WV83qW5wc7tUoJ/mNOVHcuBloDTswfzfqNyFI9qxOuW6sJbAuPwTsQQyA6kK/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675440494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OUXphYDMEjjOy/RkTJz/AoqLtbS6znact/XPaEgzTtg=; b=UDMHlyG00f2tXKlWu2ABy1798x+7PigEadT3LfR1mRVIIjACExflH3m5fCI9MeQ579ZTVE abHSWHQpHdDROfc/iH7UzsM4x7G7QStykNtFw0zxxu61KwAbilVTXwXO3XMFpI8BUHLWr2 NeAtdZTxfo8DXFDthKONBoEPiBQl6KGwwGwO3yxCUx2Mn8wFZ5ahp9A1zhT7eY8Moc0mP2 0/sa45h3wPEfM5oEo8DZrVFmBVZAnT9Tv5tz/H/HP1b9qMkNRYMkHKdcIbaYPR1xR3N3r8 D0B4JB54nDM/8lzgXpG53rPmoob5q5l9Iv+sgNyzLuj5mJwI1J3nKEtSZk3Klg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675440494; a=rsa-sha256; cv=none; b=ot8IqSzq7llT2Kmmzm0IASjqplS9V4qP42SYBF4yJuWjTrSqxaQfxjgKDuUzTNUnxgGBqs E3+Yr7jp4zd2DQOPL9EWkm6EGK6KsAy863Xd6ct//h6ZHIi2W6Xte4ISIufDFlYHRl82GK +u31f07TJFkyQSXt28c6qhA6zrOYyYmEUZoXxERUkg7hS2GWYSTumwxREA67UfoB33TyQ2 AbMiSZ0+xcpjfjDhpvG9v5Lx9RelQWqciqZYl6rMxuzKKJs1gziwPv/WLvTW9pH6+sXeB3 41mxcm7mVDzNrGUv+MYGgh5H5gN3p5/qRC2YZbEKTXXZW7MRlSBC5vQfY5QWhg== Received: from ltc.des.no (unknown [178.232.223.163]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4P7gYV0PWvz11Vg; Fri, 3 Feb 2023 16:08:14 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.no (Postfix, from userid 1001) id 4D20EF9BD6; Fri, 3 Feb 2023 17:08:11 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: "Rodney W. Grimes" Cc: rgrimes@freebsd.org, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: cb96a0ef0040 - main - cp: Minor code cleanup. In-Reply-To: <202302031558.313Fw2sJ051540@gndrsh.dnsmgr.net> (Rodney W. Grimes's message of "Fri, 3 Feb 2023 07:58:02 -0800 (PST)") References: <202302031558.313Fw2sJ051540@gndrsh.dnsmgr.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (berkeley-unix) Date: Fri, 03 Feb 2023 17:08:11 +0100 Message-ID: <86lele3f6c.fsf@ltc.des.no> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N "Rodney W. Grimes" writes: > Wouldnt it now be possible for code in the fts_read path to reference > errno unintialized? Can you provide a test case? We (cp) only look at errno if fts_read() returns NULL, and that only happens after an error (errno is expected to be set) or when we're done (fts_read() explicitly sets errno to 0). DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org