From owner-svn-src-stable-10@freebsd.org Fri Apr 22 21:49:49 2016 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5862CB18EAE; Fri, 22 Apr 2016 21:49:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 396E017C7; Fri, 22 Apr 2016 21:49:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 00491B94A; Fri, 22 Apr 2016 17:49:48 -0400 (EDT) From: John Baldwin To: Garrett Cooper Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r298491 - stable/10/lib/msun/tests Date: Fri, 22 Apr 2016 14:49:43 -0700 Message-ID: <1686086.xOFMeakFfv@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201604222132.u3MLW1jx083176@repo.freebsd.org> References: <201604222132.u3MLW1jx083176@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 22 Apr 2016 17:49:48 -0400 (EDT) X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 21:49:49 -0000 On Friday, April 22, 2016 09:32:01 PM Garrett Cooper wrote: > Author: ngie > Date: Fri Apr 22 21:32:01 2016 > New Revision: 298491 > URL: https://svnweb.freebsd.org/changeset/base/298491 > > Log: > MFC r297836: > > Fix appending -O0 to CFLAGS > > The previous method would completely nerf CFLAGS once bsd.progs.mk had > recursed into the per-PROG logic and make the CFLAGS for tap testcases > to -O0, instead of appending to CFLAGS for all of the tap testcases. Eh, Bryan replied to the commit that put this into HEAD saying it was a no-op but you didn't reply. Shouldn't you address that first before MFC'ing? -- John Baldwin