From owner-freebsd-stable@freebsd.org Wed May 5 09:47:40 2021 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2D63B638028; Wed, 5 May 2021 09:47:40 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FZsMH4pt7z3Q2Z; Wed, 5 May 2021 09:47:39 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from [192.168.0.88] (unknown [195.64.148.76]) (Authenticated sender: andriy.gapon@uabsd.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id DF356100012; Wed, 5 May 2021 09:47:36 +0000 (UTC) Subject: Re: ZFS rename with associated snapshot present: odd error message To: Mark Millard , FreeBSD-STABLE Mailing List Cc: freebsd-current References: <8335C81D-B83C-42BC-B296-C05FAEAE538A.ref@yahoo.com> <8335C81D-B83C-42BC-B296-C05FAEAE538A@yahoo.com> From: Andriy Gapon Message-ID: <4ddf96da-e7f7-663d-8539-04f91297389a@FreeBSD.org> Date: Wed, 5 May 2021 12:47:35 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <8335C81D-B83C-42BC-B296-C05FAEAE538A@yahoo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FZsMH4pt7z3Q2Z X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2021 09:47:40 -0000 On 05/05/2021 01:59, Mark Millard via freebsd-current wrote: > I had a: > > # zfs list -tall > NAME USED AVAIL REFER MOUNTPOINT > . . . > zroot/DESTDIRs/13_0R-CA72-instwrld-norm 1.44G 117G 96K /usr/obj/DESTDIRs/13_0R-CA72-instwrld-norm > zroot/DESTDIRs/13_0R-CA72-instwrld-norm@dirty-style 1.44G - 1.44G -. . . > . . . > > (copied/pasted from somewhat earlier) and then attempted: > > # zfs rename zroot/DESTDIRs/13_0R-CA72-instwrld-norm zroot/DESTDIRs/13_0R-CA72-instwrld-alt-0 > cannot open 'zroot/DESTDIRs/13_0R-CA72-instwrld-norm@dirty-style': snapshot delimiter '@' is not expected here > > Despite the "cannot open" message, the result looks like: > > # zfs list -tall > NAME USED AVAIL REFER MOUNTPOINT > . . . > zroot/DESTDIRs/13_0R-CA72-instwrld-alt-0 1.44G 114G 96K /usr/obj/DESTDIRs/13_0R-CA72-instwrld-alt-0 > zroot/DESTDIRs/13_0R-CA72-instwrld-alt-0@dirty-style 1.44G - 1.44G - > . . . > > Still, it leaves me wondering if everything is okay > given that internal attempt to use the old name with > @dirty-style when it was apparently no longer > available under that naming. > > For reference: > > # uname -apKU > FreeBSD CA72_4c8G_ZFS 13.0-RELEASE FreeBSD 13.0-RELEASE #0 releng/13.0-n244733-ea31abc261ff-dirty: Thu Apr 29 21:53:20 PDT 2021 root@CA72_4c8G_ZFS:/usr/obj/BUILDs/13_0R-CA72-nodbg-clang/usr/13_0R-src/arm64.aarch64/sys/GENERIC-NODBG-CA72 arm64 aarch64 1300139 1300139 Cannot reproduce here (but with much simpler names and on stable/13): zfs create testz/test zfs snapshot testz/test@snap1 zfs rename testz/test testz/test2 All worked. -- Andriy Gapon