From owner-svn-src-head@freebsd.org Sat Feb 17 15:07:34 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 174E0F169FF for ; Sat, 17 Feb 2018 15:07:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9C09E83C23 for ; Sat, 17 Feb 2018 15:07:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x232.google.com with SMTP id o9so929371itc.1 for ; Sat, 17 Feb 2018 07:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=LMc55vynpfNpP2IZ03Giy9p/nvQTjNytGUd/ZaEoEqw=; b=LLFtguy5mU9HZM55Q5sGt205tcj2yV3gqhAuHG1D2MBK8a+9fjSE1BxQvGry6uVeBP UMwgAeyemzpBn4sGuieVq682L/AaALokKQcDK5NTYQFgv+B1Qx8VJy8THI2Y0RmhP/UC IPv0rdhkjB1z9YyuV2TBfINvuh/au8UfxAa9/tqwX+4d4Q4Dza21lo3DLGgHo3rnBwgK /bWaWQ8KEag3JvuvbHmNzvjq3gXYbA9mLGlYvbnim/OzMARjICyakhP6QT5DT2jn72r1 UkXJlm0bhNjhPVu1R4WwLchBA7Px03quba913uB8398KqLOJ0Cqq9lN3BD951+7NTcui uYbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=LMc55vynpfNpP2IZ03Giy9p/nvQTjNytGUd/ZaEoEqw=; b=sYSuU8TjHhTDe5C5JiKGaLiGt1pEu75Jec17yyuiaJ2qfDboGmnxO9tokIFexu6N9D EHYhFpFM2v4b67QTy3Z9MuIYrnbgIc/zNP/6rt+CqTDF7upAumaf8yfn2/z1Hl5s5SND Uo16Wat3XWkFHaSuRt4au/MdnUDuUftcJO13Kti3GaCHYYEgmuC82k62y90SLtMfopgc adp4/c+c0IN9Mkq40B5EAePY/QKOlcQQss4PI7Dv5eF7m/DBMUtBV9tcfqSZv06rafLZ VazsedyBJ2wLXx1d4VSMefjIltv1gKnPIQ4yS8gD/QRYh7OYt1ZsexUMlVendhDeRMv4 pwFg== X-Gm-Message-State: APf1xPAus7VaEimeEwyJ5HCY5QZQLst1A/s0x8vnzDNViUDPIYyqqfgi 4pVzpAg55LziBqLCTcW0eq89TbKvV71W7g2KFe+Cgg== X-Google-Smtp-Source: AH8x224lM9KpVMHHDudWZ6qwzekaHsDivuhJFusz2SaoEnz+sp9E3WEoRv/geacEaHaxr2fgDgbCIR9xGRyHZKpvrG0= X-Received: by 10.36.55.146 with SMTP id r140mr2101041itr.57.1518880053045; Sat, 17 Feb 2018 07:07:33 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Sat, 17 Feb 2018 07:07:32 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <5b49c102-ad07-cfdb-2e45-e27cee99ee81@selasky.org> References: <201802171434.w1HEYl8I063603@repo.freebsd.org> <5b49c102-ad07-cfdb-2e45-e27cee99ee81@selasky.org> From: Warner Losh Date: Sat, 17 Feb 2018 08:07:32 -0700 X-Google-Sender-Auth: dbe2BymbcSBsk2bhC3o3wvmXqvQ Message-ID: Subject: Re: svn commit: r329458 - head/sbin/devmatch To: Hans Petter Selasky Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Feb 2018 15:07:34 -0000 On Sat, Feb 17, 2018 at 7:58 AM, Hans Petter Selasky wrote: > On 02/17/18 15:56, Warner Losh wrote: > >> I'd request you make no further changes to devmatch without a review. >> > > I don't have a problem with that. > > You can see now what changes are needed. Please make sure you test with > real USB devices! Some people are using FreeBSD-current on desktops, and > the USB auto-load feature has been broken for almost a week now. (a) It's current (b) It took longer to sort out than I'd hoped (c) I tested with a keyboard and mouse on my main server. It was absolutely tested. Snide comments like this aren't helping my already grumpy mood over this. It would be more helpful if you could turn on devd's logging (by adding !devd *.>=info /var/log/devd.log to /etc/syslog.conf, restarting syslog and then giving me the exact scenario that's failing so I can add it to a test suite I'm writing. The data will be in /var/log/devd.log. I can't possibly test all the crazy USB scenarios with the hardware I have (there's too many of them), but I can test it in simulation and make sure we're good. The multiple driver matching thing was never ever mentioned in prior things, so getting snippy with me over it for not testing it is not helpful. Understanding what to look for will be helpful in making sure the test suites catch it and we fix the underlying issues. Warner