Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Feb 2018 08:07:32 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Hans Petter Selasky <hps@selasky.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r329458 - head/sbin/devmatch
Message-ID:  <CANCZdfphV7XgZ14HPPDhtiFbmNPjCS4DVSdeZf7n-58XTm_NHw@mail.gmail.com>
In-Reply-To: <5b49c102-ad07-cfdb-2e45-e27cee99ee81@selasky.org>
References:  <201802171434.w1HEYl8I063603@repo.freebsd.org> <CANCZdfrevbHxoRmV4HyjR9j%2B4%2BHbCU8H-aUhuhHjaySA=hwrsA@mail.gmail.com> <5b49c102-ad07-cfdb-2e45-e27cee99ee81@selasky.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 17, 2018 at 7:58 AM, Hans Petter Selasky <hps@selasky.org>
wrote:

> On 02/17/18 15:56, Warner Losh wrote:
>
>> I'd request you make no further changes to devmatch without a review.
>>
>
> I don't have a problem with that.
>
> You can see now what changes are needed. Please make sure you test with
> real USB devices! Some people are using FreeBSD-current on desktops, and
> the USB auto-load feature has been broken for almost a week now.


(a) It's current (b) It took longer to sort out than I'd hoped (c) I tested
with a keyboard and mouse on my main server. It was absolutely tested.
Snide comments like this aren't helping my already grumpy mood over this.

It would be more helpful if you could turn on devd's logging (by adding
!devd
*.>=info                                       /var/log/devd.log
to /etc/syslog.conf, restarting syslog and then giving me the exact
scenario that's failing so I can add it to a test suite I'm writing. The
data will be in /var/log/devd.log. I can't possibly test all the crazy USB
scenarios with the hardware I have (there's too many of them), but I can
test it in simulation and make sure we're good.

The multiple driver matching thing was never ever mentioned in prior
things, so getting snippy with me over it for not testing it is not
helpful. Understanding what to look for will be helpful in making sure the
test suites catch it and we fix the underlying issues.

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfphV7XgZ14HPPDhtiFbmNPjCS4DVSdeZf7n-58XTm_NHw>