From owner-svn-src-user@FreeBSD.ORG Thu Oct 14 20:39:23 2010 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41075106566C; Thu, 14 Oct 2010 20:39:23 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 034D58FC12; Thu, 14 Oct 2010 20:39:22 +0000 (UTC) Received: by pwi6 with SMTP id 6so190378pwi.13 for ; Thu, 14 Oct 2010 13:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:organization:x-operation-sytem; bh=55KK0uWD3qAUDpP+Wq6xipiEoPmvk+CU9Vx+W3fM7pg=; b=NgBUIY3dSE822x2qhWWRCI6Ivh3emfTfNFEtVBVHfi8XxcR1Hojqlqufs78U0gq4TL TBvTaDlxyTVz0jJxCddEBNNjemISOjjkneDVyDuzxj35lGUEp44TrUTOGQwyIIny9Twr x+knhO4O2fACmOBeJ/AfSOxaN76zcZZuhShzM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:organization:x-operation-sytem; b=qfwDUS0djLla+knHK2/csUJjY6PmgGWW18vg9JmMkFuIShY4UC708i2JBN01JLIdP3 bamyNREo7cLl9bYyvbDlxjicFR9o0VpsWxHsXJTkO0SiawIcAFh7GI/zdeF2QPJJE67u bsfDbMM4wQqzj+lEX81+Y/SmrflsP2Vz11ICw= Received: by 10.142.166.20 with SMTP id o20mr8392684wfe.382.1287088762354; Thu, 14 Oct 2010 13:39:22 -0700 (PDT) Received: from weongyo ([174.35.1.224]) by mx.google.com with ESMTPS id w14sm14235946wfd.6.2010.10.14.13.39.21 (version=SSLv3 cipher=RC4-MD5); Thu, 14 Oct 2010 13:39:21 -0700 (PDT) Received: by weongyo (sSMTP sendmail emulation); Thu, 14 Oct 2010 13:39:32 -0700 From: Weongyo Jeong Date: Thu, 14 Oct 2010 13:39:32 -0700 To: Hans Petter Selasky Message-ID: <20101014203932.GK38869@weongyo> Mail-Followup-To: Hans Petter Selasky , "src-committers@freebsd.org" , "svn-src-user@freebsd.org" References: <201010142004.o9EK458X035369@svn.freebsd.org> <201010142219.08408.hselasky@c2i.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201010142219.08408.hselasky@c2i.net> User-Agent: Mutt/1.4.2.3i Organization: CDNetworks. X-Operation-Sytem: FreeBSD Cc: "src-committers@freebsd.org" , "svn-src-user@freebsd.org" Subject: Re: svn commit: r213847 - user/weongyo/usb/sys/dev/usb X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Weongyo Jeong List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Oct 2010 20:39:23 -0000 On Thu, Oct 14, 2010 at 10:19:08PM +0200, Hans Petter Selasky wrote: > On Thursday 14 October 2010 22:04:05 Weongyo Jeong wrote: > > + for (i = 0; i < up->up_frames; i++) { > > + if (ptr + sizeof(u_int32_t) >= end) > > + goto done; > > + *((u_int32_t *)ptr) = xfer->frlengths[i]; > > + ptr += sizeof(u_int32_t); > > + > > + if (ptr + xfer->frlengths[i] >= end) > > + goto done; > > + usbd_get_page(&xfer->frbuffers[i], 0, &res); > > + bcopy(res.buffer, ptr, xfer->frlengths[i]); > > + ptr += xfer->frlengths[i]; > > + } > > For isochronous transfers only the first frbuffer is used for all transfers, > which are back to back. Do you mean that we should dump only xfer->frbuffers[0] even if xfer->nframes > 1 for isochronous xfer? regards, Weongyo Jeong