Date: Thu, 14 Oct 2010 13:39:32 -0700 From: Weongyo Jeong <weongyo.jeong@gmail.com> To: Hans Petter Selasky <hselasky@c2i.net> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-user@freebsd.org" <svn-src-user@freebsd.org> Subject: Re: svn commit: r213847 - user/weongyo/usb/sys/dev/usb Message-ID: <20101014203932.GK38869@weongyo> In-Reply-To: <201010142219.08408.hselasky@c2i.net> References: <201010142004.o9EK458X035369@svn.freebsd.org> <201010142219.08408.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 14, 2010 at 10:19:08PM +0200, Hans Petter Selasky wrote:
> On Thursday 14 October 2010 22:04:05 Weongyo Jeong wrote:
> > + for (i = 0; i < up->up_frames; i++) {
> > + if (ptr + sizeof(u_int32_t) >= end)
> > + goto done;
> > + *((u_int32_t *)ptr) = xfer->frlengths[i];
> > + ptr += sizeof(u_int32_t);
> > +
> > + if (ptr + xfer->frlengths[i] >= end)
> > + goto done;
> > + usbd_get_page(&xfer->frbuffers[i], 0, &res);
> > + bcopy(res.buffer, ptr, xfer->frlengths[i]);
> > + ptr += xfer->frlengths[i];
> > + }
>
> For isochronous transfers only the first frbuffer is used for all transfers,
> which are back to back.
Do you mean that we should dump only xfer->frbuffers[0] even if
xfer->nframes > 1 for isochronous xfer?
regards,
Weongyo Jeong
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101014203932.GK38869>