From owner-svn-ports-head@freebsd.org Fri Sep 30 03:24:13 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7CE3DC0339E; Fri, 30 Sep 2016 03:24:13 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 586BC1A8A; Fri, 30 Sep 2016 03:24:12 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [127.0.0.1] (ip70-178-28-115.ks.ks.cox.net [70.178.28.115]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id C570643CF0; Thu, 29 Sep 2016 22:23:55 -0500 (CDT) Subject: Re: svn commit: r422939 - in head/cad/gmsh: . files To: Joseph Mingrone , marino@freebsd.org References: <201609291915.u8TJFYnY043558@repo.freebsd.org> <5c5b4064-3037-8a29-9c73-6efc00d4355f@marino.st> <86shsi8dri.fsf@phe.ftfl.ca> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Reply-To: marino@freebsd.org From: John Marino Message-ID: <7c99998c-31df-2fd7-d9ff-355adb043820@marino.st> Date: Thu, 29 Sep 2016 22:24:09 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <86shsi8dri.fsf@phe.ftfl.ca> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 160929-1, 09/29/2016), Outbound message X-Antivirus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 03:24:13 -0000 On 9/29/2016 18:52, Joseph Mingrone wrote: > Hi John, > > John Marino writes: >> On 9/29/2016 14:15, Joseph Mingrone wrote: >>> Author: jrm Date: Thu Sep 29 19:15:34 2016 New Revision: 422939 >>> URL: https://svnweb.freebsd.org/changeset/ports/422939 > >>> Log: Update cad/gmsh to 2.13.2; fix knob issue; other changes > >>> - Remove MAKE_JOBS_UNSAFE=yes > >> I'm curious about this one. Was this specifically addressed in the >> release notes? or in other words, how did you confirm this port is >> now jobs safe? > > I looked at the commit log, but there was no mention of the reason > why this was added. I ran the build through 'poudriere testport' and > looked over the output. Should I be checking something else? > In my opinion, to remove MAKE_JOBS_UNSAFE, first the unsafe operation of the previous version has to be identified and then it has to be confirmed that the new version has explicitly fixed it. If you don't have proof of the fix, then conservatively you have to assume it's still not jobs-safe. A single positive build isn't enough to change the setting. It could only show under a heavily loaded server, and only some times, for example, and your run didn't provide similar conditions. It's unfortunate the commit log didn't detail the original problem. I seem to recall also hitting jobs unsafe problems with this port and I would not be surprised if they come back now. John --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus