From owner-svn-src-all@freebsd.org Fri Jan 11 19:25:03 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A32A0149A0FD; Fri, 11 Jan 2019 19:25:03 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DFD0B82687; Fri, 11 Jan 2019 19:25:02 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x0BJP0je022635; Fri, 11 Jan 2019 11:25:00 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x0BJP0Ac022634; Fri, 11 Jan 2019 11:25:00 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201901111925.x0BJP0Ac022634@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r342948 - head/share/man/man9 In-Reply-To: To: Kyle Evans Date: Fri, 11 Jan 2019 11:25:00 -0800 (PST) CC: "Rodney W. Grimes" , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: DFD0B82687 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.963,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 19:25:04 -0000 > On Fri, Jan 11, 2019 at 1:13 PM Rodney W. Grimes > wrote: > > > > > Author: imp > > > Date: Fri Jan 11 19:05:40 2019 > > > New Revision: 342948 > > > URL: https://svnweb.freebsd.org/changeset/base/342948 > > > > > > Log: > > > Add man page for device_delete_children. > > > > > > Submitted by: Jeroen Ruigrok van der Werven > > > Differential Revision: https://reviews.freebsd.org/D18452 > > > > > > Added: > > > head/share/man/man9/device_delete_children.9 (contents, props changed) > > > Modified: > > > head/share/man/man9/Makefile > > > > > > Modified: head/share/man/man9/Makefile > > > ============================================================================== > > > --- head/share/man/man9/Makefile Fri Jan 11 16:18:23 2019 (r342947) > > > +++ head/share/man/man9/Makefile Fri Jan 11 19:05:40 2019 (r342948) > > > @@ -90,6 +90,7 @@ MAN= accept_filter.9 \ > > > device_add_child.9 \ > > > DEVICE_ATTACH.9 \ > > > device_delete_child.9 \ > > > + device_delete_children.9 \ > > > DEVICE_DETACH.9 \ > > > device_enable.9 \ > > > device_find_child.9 \ > > > > > > Added: head/share/man/man9/device_delete_children.9 > > > ============================================================================== > > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > > +++ head/share/man/man9/device_delete_children.9 Fri Jan 11 19:05:40 2019 (r342948) > > > @@ -0,0 +1,58 @@ > > > +.\" -*- nroff -*- > > > +.\" > > > +.\" Copyright (c) 2018 Jeroen Ruigrok van der Werven > > > +.\" > > > +.\" All rights reserved. > > > > We should be very carefull about white space between a copyright > > statement and the All Rights reserved clause of that copyright > > statement (we actual prefer not to have those words) as this > > leads to Copyrights inserted between the 2 which disjoin the > > all rights reserved from the copyright that is asserting it. > > > > Could you please ask the author if we can strike the > > All rights reserved, and if not please remove the white > > space between them. > > > > Perhaps also a SPDX tag for this while we're potentially changing the area? I wont express an opionion on that, but when you mentioned this I went back and looked at the commit, and right below the above is an additional line: +.\ This program is free software I am not sure if that even makes since, it is not a program, it is a manual page, and I am also not sure on how that affects the following BSD 2 clause. I normally associated those words with the GPL. Which leads me to wonder, did this file have a GPL on it and it got "removed" but left a tiny residual behind? I also find many instances of this in our tree, so this may come from a copy and paste. IMHO that line should also die. -- Rod Grimes rgrimes@freebsd.org