From owner-freebsd-net@FreeBSD.ORG  Wed Jan  7 22:35:32 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 607BF106587F
	for <freebsd-net@freebsd.org>; Wed,  7 Jan 2009 22:35:32 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 2E4898FC16
	for <freebsd-net@freebsd.org>; Wed,  7 Jan 2009 22:35:31 +0000 (UTC)
	(envelope-from sam@freebsd.org)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n07MZHob065362
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 7 Jan 2009 14:35:17 -0800 (PST) (envelope-from sam@freebsd.org)
Message-ID: <49652E25.9030705@freebsd.org>
Date: Wed, 07 Jan 2009 14:35:17 -0800
From: Sam Leffler <sam@freebsd.org>
Organization: FreeBSD Project
User-Agent: Thunderbird 2.0.0.18 (X11/20081209)
MIME-Version: 1.0
To: Jack Vogel <jfvogel@gmail.com>
References: <000001c970a8$3fa45240$220f000a@mtl.com>	
	<4964C2E9.1060301@bestunion.it>	
	<000001c970d9$4403e590$220f000a@mtl.com>	
	<4964EC4F.8030507@freebsd.org>
	<2a41acea0901071359w3f41465ajb8206cdef5b7b680@mail.gmail.com>
In-Reply-To: <2a41acea0901071359w3f41465ajb8206cdef5b7b680@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC--Metrics: ebb.errno.com; whitelist
Cc: Eitan Shefi <eitans@mellanox.co.il>, Angelo Turetta <aturetta@bestunion.it>,
	Yony Yossef <yonyossef.lists@gmail.com>, freebsd-net@freebsd.org
Subject: Re: VLAN interface management - unloading carrying driver hangs the
 machine
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Jan 2009 22:35:36 -0000

Jack Vogel wrote:
>
>
> On Wed, Jan 7, 2009 at 9:54 AM, Sam Leffler <sam@freebsd.org 
> <mailto:sam@freebsd.org>> wrote:
>
>     Yony Yossef wrote:
>
>             Yony Yossef wrote:
>                
>
>                 /sbin/ifconfig vlan3653 create
>
>                 Problem is when I assign an IP to the vlan interface.
>                 In that case, unloading the driver results in hanging
>                 the host.
>                  Does it sound familiar to anybody?
>                      
>
>             Well, surely I'd expect problems by doing so.
>             The correct way is to
>
>                    /sbin/ifconfig vlan3653 destroy
>
>             before unloading the driver.
>
>             Angelo.
>                
>
>
>         Thanks, I didn't know freebsd does not allow it.
>
>          
>
>     This seems wrong. Someone should disallow the driver
>     detach/unload. Please file a PR about this so the issue is not lost.
>
>     Sam
>
>
> In many drivers, ahem, like mine, there is a test at detach and it 
> will not allow it if there
> is a non-NULL trunk.
>
> Sounds like a broken driver needs to be fixed is all...
>
I don't agree; drivers should not be required to deal with this.  If 
someone files a PR and assigns it to me I'll look at it.

    Sam