From owner-cvs-all@FreeBSD.ORG Sat Sep 27 15:41:01 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A92EC1065690; Sat, 27 Sep 2008 15:41:01 +0000 (UTC) (envelope-from ganbold@micom.mng.net) Received: from publicd.ub.mng.net (publicd.ub.mng.net [202.179.0.88]) by mx1.freebsd.org (Postfix) with ESMTP id 5B61E8FC20; Sat, 27 Sep 2008 15:41:01 +0000 (UTC) (envelope-from ganbold@micom.mng.net) Received: from [202.179.21.128] (helo=devil.micom.mng.net) by publicd.ub.mng.net with esmtpa (Exim 4.69 (FreeBSD)) (envelope-from ) id 1Kjbul-000FQE-08; Sat, 27 Sep 2008 23:40:59 +0800 Message-ID: <48DE5409.6060704@micom.mng.net> Date: Sat, 27 Sep 2008 23:40:57 +0800 From: Ganbold User-Agent: Thunderbird 2.0.0.16 (X11/20080901) MIME-Version: 1.0 To: Roman Kurakin References: <200809271430.m8REUkDV034473@repoman.freebsd.org> <48DE49E8.2060602@micom.mng.net> <48DE4C09.5050903@localhost.inse.ru> In-Reply-To: <48DE4C09.5050903@localhost.inse.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Roman Kurakin , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ipfw ipfw2.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Sep 2008 15:41:01 -0000 Roman, Roman Kurakin wrote: > Ganbold wrote: >> Roman Kurakin wrote: >>> rik 2008-09-27 14:30:34 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sbin/ipfw ipfw2.c Log: >>> SVN rev 183407 on 2008-09-27 14:30:34Z by rik >>> Add keyword all in addtion to the table number for the 'list' >>> and the >>> 'flush' actions on tables. Part of PR: 127058. >>> >> >> Thanks a lot, Roman. > With the last one just committed the all parts of PR should now be done. > So please test all the parts (also 'table all flush' as a bonus) and I > will close > the PR. ... cc -O2 -pipe -fstack-protector -Wno-pointer-sign -c /usr/src/sbin/ipfw/ipfw2.c /usr/src/sbin/ipfw/ipfw2.c: In function 'table_handler': /usr/src/sbin/ipfw/ipfw2.c:5969: error: too few arguments to function 'table_list' *** Error code 1 Stop in /usr/src/sbin/ipfw. You forgot to add is_all as argument to table_list(): ... } else if (_substrcmp(*av, "list") == 0) { a = is_all ? tables_max : (ent.tbl + 1); do { table_list(ent, is_all); ^^^^ } while (++ent.tbl < a); } else ... Corrected version works, lists all tables' IP and flushes all. Will check man page shortly. thanks, Ganbold > > rik >> Ganbold >> >>> PR: 127058 (based on) >>> MFC after: 1 month >>> Revision Changes Path >>> 1.129 +29 -8 src/sbin/ipfw/ipfw2.c >>> _______________________________________________ >>> cvs-all@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/cvs-all >>> To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" >>> >>> >>> >>> >> > > _______________________________________________ > cvs-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-all > To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" > > > -- A master programmer passed a novice programmer one day. The master noted the novice's preoccupation with a hand-held computer game. "Excuse me", he said, "may I examine it?" The novice bolted to attention and handed the device to the master. "I see that the device claims to have three levels of play: Easy, Medium, and Hard", said the master. "Yet every such device has another level of play, where the device seeks not to conquer the human, nor to be conquered by the human." "Pray, great master," implored the novice, "how does one find this mysterious setting?" The master dropped the device to the ground and crushed it under foot. And suddenly the novice was enlightened. -- Geoffrey James, "The Tao of Programming"