From owner-freebsd-arch@FreeBSD.ORG Wed Mar 8 16:04:13 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E1F216A420 for ; Wed, 8 Mar 2006 16:04:13 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14C9343D45 for ; Wed, 8 Mar 2006 16:04:13 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id k28G27bq024890; Wed, 8 Mar 2006 09:02:07 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 08 Mar 2006 09:02:11 -0700 (MST) Message-Id: <20060308.090211.97454770.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <440EF0B0.1010203@samsco.org> References: <20060307.233728.42821161.imp@bsdimp.com> <20060308092207.GB679@turion.vk2pj.dyndns.org> <440EF0B0.1010203@samsco.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 08 Mar 2006 09:02:07 -0700 (MST) Cc: arch@freebsd.org Subject: Re: cvs commit: src/sys/vm swap_pager.c vm_fault.c vm_map.c vm_page.c vm_pageq.c X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2006 16:04:13 -0000 In message: <440EF0B0.1010203@samsco.org> Scott Long writes: : Peter Jeremy wrote: : > On Tue, 2006-Mar-07 23:37:28 -0700, M. Warner Losh wrote: : > : >>This is the first commit of many to do what the comment says. : > : > ... : > : >> Log: : >> Remove leading __ from __(inline|const|signed|volatile). They are : >> obsolete. This should reduce diffs to NetBSD as well. : > : > : > K&R function definitions are even more obsolete but still used : > throughout the kernel. IMHO, potential diff-reduction to NetBSD : > seems a fairly flimsy reason for a significant amount of churn. : > : > Also, any diff reduction with NetBSD is probably outweighed by : > the diff increase with other FreeBSD branches. : > : > Maybe this should be treated like whitespace cleanup - something to : > do if you're going to be doing something non-trivial in the source : > file. (There are probably other cleanups in the same category). : > : : Yeah, diff increase with other FreeBSD branches is a big deal. While : sharing between RELENG_4 and more recent branches is pretty hard these : days, a lot can be shared between RELENG_5, RELENG_6, and HEAD. Would merging these to RELENG_6 help any? RELENG_5 is dead after this release anyway... After all, with the new release cycle, there would never be a good time to remove this old cruft from the tree since we'd always have multiple branches to deal with. Anyway, given some of the nasty comments I got I'm going to do this only as I have to change other things in the tree for the moment. Warner