From owner-cvs-all Fri Sep 13 10:29:42 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DDE9537B401; Fri, 13 Sep 2002 10:29:36 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 854DA43E4A; Fri, 13 Sep 2002 10:29:35 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id DAA00665; Sat, 14 Sep 2002 03:29:33 +1000 Date: Sat, 14 Sep 2002 03:33:58 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/kern vfs_bio.c src/sys/sys bio.h In-Reply-To: <200209131128.g8DBSY14039266@freefall.freebsd.org> Message-ID: <20020914032217.V10972-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 13 Sep 2002, Poul-Henning Kamp wrote: > phk 2002/09/13 04:28:34 PDT > > Modified files: > sys/kern vfs_bio.c > sys/sys bio.h > Log: > Oops, broke the build there. Uninline biodone() now that it is non-trivial. > > Introduce biowait() function. Currently there is a race condition and the > mitigation is a timeout/retry. It is not obvious what kind of locking (if any) > is suitable for BIO_DONE, since the majority of users take are of this > themselves, and only a few places actually rely on the wakeup. > > Sponsored by: DARPA & NAI Labs. Isn't the "correct" locking just splbio() in RELENG_4 (if this function were merged, haha) and Giant in -current. bufwait() just uses splbio() unconditionally. Of course, Giant is not really correct. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message