From owner-cvs-all Sun Dec 2 12:28:42 2001 Delivered-To: cvs-all@freebsd.org Received: from freesbee.wheel.dk (freesbee.wheel.dk [193.162.159.97]) by hub.freebsd.org (Postfix) with ESMTP id 4D0C437B416; Sun, 2 Dec 2001 12:28:29 -0800 (PST) Received: by freesbee.wheel.dk (Postfix, from userid 1001) id C65955D34; Sun, 2 Dec 2001 21:28:27 +0100 (CET) Date: Sun, 2 Dec 2001 21:28:27 +0100 From: Jesper Skriver To: John Baldwin Cc: Mike Barcroft , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Josef Karthauser Subject: Re: cvs commit: CVSROOT cfg.pm log_accum.pl Message-ID: <20011202212827.D36916@skriver.dk> Mail-Followup-To: Jesper Skriver , John Baldwin , Mike Barcroft , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Josef Karthauser References: <20011201214307.A46242@espresso.q9media.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Sat, Dec 01, 2001 at 07:55:15PM -0800 X-PGP-Fingerprint: 6B88 9CE8 66E9 E631 C9C5 5EB4 22AB F0EC F956 1C31 X-PGP-Public-Key: http://freesbee.wheel.dk/~jesper/gpgkey.pub Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Dec 01, 2001 at 07:55:15PM -0800, John Baldwin wrote: > > On 02-Dec-01 Mike Barcroft wrote: > > Josef Karthauser writes: > >> joe 2001/12/01 03:38:44 PST > >> > >> Modified files: > >> . cfg.pm log_accum.pl > >> Log: > >> Add the ability to have diffs inserted into the commit email. > >> > >> Submitted by: jesper > >> > >> Revision Changes Path > >> 1.44 +5 -2 CVSROOT/cfg.pm > >> 1.114 +73 -0 CVSROOT/log_accum.pl > > > > cvs-verbose@FreeBSD.org anyone? This would lower the barrier to entry > > for reviewing commits. > > Does it limit the length? p4 submit mails trim the output at 1000 lines. > Otherwise imports of vendor software could be some _very_ large e-mails. :) The variable which enable it, it a size limiter, if you set i to 1, the diff of a given file will only be shown if it's less than 1 kbyte ... /Jesper -- Jesper Skriver, jesper(at)skriver(dot)dk - CCIE #5456 Work: Network manager @ AS3292 (Tele Danmark DataNetworks) Private: FreeBSD committer @ AS2109 (A much smaller network ;-) One Unix to rule them all, One Resolver to find them, One IP to bring them all and in the zone to bind them. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message