From owner-cvs-all Thu Jan 16 22:21:33 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 935CE37B401; Thu, 16 Jan 2003 22:21:31 -0800 (PST) Received: from gateway.posi.net (adsl-63-201-91-32.dsl.snfc21.pacbell.net [63.201.91.32]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45F2F43EB2; Thu, 16 Jan 2003 22:21:24 -0800 (PST) (envelope-from kbyanc@posi.net) Received: from localhost (localhost [127.0.0.1]) by gateway.posi.net (8.12.6/8.12.6) with ESMTP id h0H6L5Al036707; Thu, 16 Jan 2003 22:21:06 -0800 (PST) (envelope-from kbyanc@posi.net) Date: Thu, 16 Jan 2003 22:21:05 -0800 (PST) From: Kelly Yancey To: Paul Richards Cc: Kelly Yancey , , Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw.c ipfw2.c In-Reply-To: <20030113140921.GH35226@survey.codeburst.net> Message-ID: <20030116221911.A36702-100000@gateway.posi.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 13 Jan 2003, Paul Richards wrote: > On Mon, Dec 23, 2002 at 12:08:21PM -0800, Kelly Yancey wrote: > > kbyanc 2002/12/23 12:08:21 PST > > > > Modified files: > > sbin/ipfw ipfw.8 ipfw.c ipfw2.c > > Log: > > Make preprocessor support more generic by passing all command-line options > > after -p except for the last (the ruleset file to process) to the > > preprocessor for interpretation. This allows command-line options besides > > -U and -D to be passed to cpp(1) and m4(1) as well as making it easier to > > use other preprocessors. > > I'm not sure this is a good idea. > > If you want to ensure that options are passed to the preprocessor then > they can be put in quotes rather than changing normal command line > semantics to make a certain option "magic" in that it swallows all > remaining options except the last one. This will confuse anyone who > doesn't read the documentation carefully and realises -p does this. > > Paul. > That may be, but it is certainly better than the previous behavior of the -D and -U options be extra-special. Changing it any more than I did would have broken backward compatibility for anyone using -D or -U as was documented in ipfw(8). Kelly -- Kelly Yancey -- kbyanc@{posi.net,FreeBSD.org} FreeBSD, The Power To Serve: http://www.freebsd.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message