From owner-freebsd-hackers@freebsd.org  Tue Feb 20 03:16:28 2018
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1A94F1F431
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Tue, 20 Feb 2018 03:16:28 +0000 (UTC)
 (envelope-from lists@eitanadler.com)
Received: from mail-yb0-x22c.google.com (mail-yb0-x22c.google.com
 [IPv6:2607:f8b0:4002:c09::22c])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4EAD27D030
 for <freebsd-hackers@freebsd.org>; Tue, 20 Feb 2018 03:16:28 +0000 (UTC)
 (envelope-from lists@eitanadler.com)
Received: by mail-yb0-x22c.google.com with SMTP id v135-v6so3511952ybe.2
 for <freebsd-hackers@freebsd.org>; Mon, 19 Feb 2018 19:16:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=eitanadler.com; s=0xdeadbeef;
 h=mime-version:from:date:message-id:subject:to;
 bh=Fl0M1nNFwH/I6iK+Y6wq3cDmoPk+z1zV1EIrlTv7xec=;
 b=XOqXQqAWhWqz2oGMzqhAvLTrLeEowvMpiV7UKn+NQrL03aNFa47PmchJsb2TCTnSo+
 PTwEnsTxsZi8Lg8F+dKdtLQR/qW+aA2/HUczImVcRnZ8zl83A0+KDMEuSv0rY5jhd2ce
 McxWg1oDwvigfAgGpNZh8qOIOknv9QPwXOLFQ=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
 bh=Fl0M1nNFwH/I6iK+Y6wq3cDmoPk+z1zV1EIrlTv7xec=;
 b=D8726NlZ7g2KYb09mVrE01o5lQj3Evjkq6IIFuyhslsmG1uPhfdiFJh1NmEUCEodPn
 hg9jnEFYRbeZpz67qDDaJVmalzox4Im+1S9H44cYE4BTV6WvU2C9yJ7x+lcPlC+S49hW
 3P1lZCUWKq/1BndkXvLeyIt+wyfjd+nncuagkcL/D2aZFlgrVv8K+e4elS/PhcRSjAOI
 zBHHQ+zJeEKB2Cw477bo32xvl5fkCqpqoMBVWhP7KVBcR1jWEmAGCO3itTQVglOGvKwQ
 mEJRc9oqbewTR3VLU30QSt1i0Plc1fsstaHa6RZ+65CpNE16mibHY93c2YXWExY77evL
 L6ew==
X-Gm-Message-State: APf1xPAYw9WL5PZhvxn30DczKRxpUYxaINulbTVJIpzXkue5UAmP31M1
 KbJ1rwp8Gk+MdcJF9cq/N9chWnv8Gxuttnf9L4tPRw==
X-Google-Smtp-Source: AH8x227QrSJHRZM5aj7yRq7vPbUsHarlwDx/x0gdmwcBb4jHciYIeNo6/JRYCtuY27IEVg71aSn1NwWTqFNk1YLb5Bg=
X-Received: by 10.37.194.133 with SMTP id s127mr11909630ybf.338.1519096587745; 
 Mon, 19 Feb 2018 19:16:27 -0800 (PST)
MIME-Version: 1.0
Received: by 2002:a25:dfcb:0:0:0:0:0 with HTTP; Mon, 19 Feb 2018 19:15:57
 -0800 (PST)
From: Eitan Adler <lists@eitanadler.com>
Date: Mon, 19 Feb 2018 19:15:57 -0800
Message-ID: <CAF6rxgn7eEu5WZBH93N4AMHcwCwU3cdhH3rhQunTY+Co4PvX4w@mail.gmail.com>
Subject: gf128_add can be marked as __pure2
To: John Baldwin <jhb@freebsd.org>,
 FreeBSD Hackers <freebsd-hackers@freebsd.org>, jmg@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Feb 2018 03:16:28 -0000

Is there any reason not to apply this patch?

__pure2 means  __attribute__((const)) which is correct in this case as
 gf128_add read no global memory:


Index: gfmult.h
===================================================================
--- gfmult.h (revision 329611)
+++ gfmult.h (working copy)
@@ -108,7 +108,7 @@ gf128_write(struct gf128 v, uint8_t *buf)
  be64enc(buf, v.v[1]);
 }

-static inline struct gf128 __pure /* XXX - __pure2 instead */
+static inline struct gf128 __pure2
 gf128_add(struct gf128 a, struct gf128 b)
 {
  a.v[0] ^= b.v[0];


-- 
Eitan Adler