From owner-freebsd-wireless@FreeBSD.ORG Tue Jun 24 15:19:49 2014 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8D4A4651; Tue, 24 Jun 2014 15:19:49 +0000 (UTC) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6D115255B; Tue, 24 Jun 2014 15:19:49 +0000 (UTC) Received: from [10.12.76.47] (unknown [69.164.56.1]) (using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 4669A1936DE; Tue, 24 Jun 2014 15:19:48 +0000 (UTC) Subject: Re: wireless mcast updates, ic->ic_update_mcast From: Sean Bruno Reply-To: sbruno@freebsd.org To: Adrian Chadd In-Reply-To: References: <1403366123.39384.10.camel@bruno> Content-Type: text/plain; charset="us-ascii" Date: Tue, 24 Jun 2014 08:19:47 -0700 Message-ID: <1403623187.7781.6.camel@bruno> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: "freebsd-wireless@freebsd.org" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2014 15:19:49 -0000 On Sat, 2014-06-21 at 12:47 -0700, Adrian Chadd wrote: > Well, it depends on what the hardware may want or desire to function > correctly. I've no idea what theose chips require for multicast > behaviour. > > > -a > > I think that was kind of my point of bringing this up. Only a handful of cards really implement the appropriate code. Most of the rest, implement stub functions that hide a console print message indicating missing functionality. I propose nuking most of these stub functions and wrapping the console printf in a bootverbose. sean > On 21 June 2014 08:55, Sean Bruno wrote: > > My T61 has a wpi(4) card in it. I noted that the console message "needs > > muticast update" is emitted as it doesn't implement the required > > function in its code and uses the default of the net80211 stack. I > > haven't noted any issues, but I took a journey through some of the > > wireless drivers to see what the status of implementation was. It seems > > most of the drivers stub out the required function to get rid of the > > warning. > > > > I perceive that with 6 exceptions, most of our wireless adapters don't > > have an implementation, or worse, they implement a stub to squash the > > warning. Shouldn't these stub functions be removed? Perhaps wrapp the > > net80211 default behavior in bootverbose? > > > > -- implemented ic_update_mcast() > > ath/if_ath.c -- implemented and working > > usb/wlan/if_zyd.c -- implemented and working > > usb/wlan/if_wi.c -- implemented and working > > > > -- sets a flag to default o/s behvavior? > > mwl/if_mlw.c -- function coded out, most code if 0'd out > > usb/wlan/if_upgt.c -- looks to default to whatever the o/s can do. > > usr/wlan/if_run.c -- looks to default to whatever the o/s can do > > > > -- stubbed out function to squash warning (bug?) > > iwn/if_iwn.c -- stubbed out in if_iwn to remove default error > > usb/wlan/if_rum.c -- stubbed out to remove default error > > usb/wlan/if_urtwn.c -- stubbed out to remove default error > > usb/wlan/if_urtw.c -- stubbed out to remove default error > > usr/wlan/if_uath.c -- stubbed out to remove default error > > usb/wlan/if_rsu.c -- stubbed out to remove default error > > wtap/if_wtap.c -- stubbed out to remove default error > > > > -- undefined, emits error correctly > > wpi/if_wpi.c > > bwi/if_bwi.c > > bwn/if_bwn.c > > ipw/if_ipw.c > > malo/if_malo.c > > ral/rt2560.c > > ral/rt2860.c > > ral/rt2661.c > > wi/if_wi.c > > usb/wlan/if_ural.c > > > > _______________________________________________ > > freebsd-wireless@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org"