From owner-svn-ports-head@freebsd.org Thu Jun 8 07:24:34 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39F0CBF85E3 for ; Thu, 8 Jun 2017 07:24:34 +0000 (UTC) (envelope-from r@robakdesign.com) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C320A77B6E for ; Thu, 8 Jun 2017 07:24:33 +0000 (UTC) (envelope-from r@robakdesign.com) Received: by mail-wm0-f65.google.com with SMTP id 70so5814861wme.1 for ; Thu, 08 Jun 2017 00:24:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=GxScr3yZdql0v13ozAolCzVKTKSEIv0ebj/tWsWhzLw=; b=bdSrq5IyeKtg91eJtJYMWkJ843MVOnGkhjI39xunTzBzGj3v8xxurpIyLHgLMxlKbM sfiCvamnz5wg04nzKLPCJGwvzbDyXm0f1Fqs7j1vJBH4z6yIredFE9Emp32+D4gPh3EA Dd9qW/vN6oP+7duLSjStOoCXS8HBI4TMKwBlb+GZskADC+nxP1GedtUr0uCje8sxQEbj 2ChwXtHSJhgcSsYBRx4wedEi2px5aqAU/j2ywz39jSfQDG4rLbZvRF7cIUMlgag/vsDe FNmEMB7/3g5XGKUdTL4Tq8XFE9117Sa64NqrwsKTFjvT0IvK4uMdjo+1sNxVBSp7VAnK s3LQ== X-Gm-Message-State: AKS2vOxHQ9YepuAcVA221+fGlwOe0PzZCWdpnlTsxk1wwEJa8RVR0R3u nhJlLBQ6BtCk6PSirV5D4g== X-Received: by 10.28.97.8 with SMTP id v8mr2378141wmb.72.1496906666449; Thu, 08 Jun 2017 00:24:26 -0700 (PDT) Received: from [192.168.1.62] (host86-169-146-243.range86-169.btcentralplus.com. [86.169.146.243]) by smtp.gmail.com with ESMTPSA id 18sm5385437wmt.6.2017.06.08.00.24.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Jun 2017 00:24:25 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r442588 - in head/www: nginx nginx-full From: Bartek Rutkowski In-Reply-To: <20170607220614.GB55217@FreeBSD.org> Date: Thu, 8 Jun 2017 08:24:24 +0100 Cc: Adam Weinberger , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201706042038.v54KcQMf001482@repo.freebsd.org> <20170605001807.GA55217@FreeBSD.org> <99D58682-8825-417C-81F8-EDC541D31713@FreeBSD.org> <20170607220614.GB55217@FreeBSD.org> To: "Sergey A. Osokin" X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 07:24:34 -0000 > On 7 Jun 2017, at 23:06, Sergey A. Osokin wrote: >=20 > On Tue, Jun 06, 2017 at 02:32:17PM +0100, Bartek Rutkowski wrote: >>> On 5 Jun 2017, at 01:18, Sergey A. Osokin wrote: >>>=20 >>> Hi Bartek and Adam, >>>=20 >>> I don't think I can get this, so two questions for you guys: >>> o) what was the reason to bump PORTREVISION in www/nginx? >>> o) wouldn't it btter to just bump PORTREVISION in www/nginx-full? >>=20 >> Hi Sergey, >>=20 >> Let me explain it quickly: some time ago you've removed two external = modules from www/nginx port, which is a master for www/nginx-full. The = www/nginx-full had them in default options, what caused port/pkg build = failures and to fix these I needed to remove these two no longer = existing modules from default options. After doing so, since it *does* = change the contents of the package, I needed to bump the PORTREVISION of = www/nginx-full and there were few ways of doing so, but none of them was = easy/simple as they were creating even complex scenarios in future = bumps/updates, so, after consulting possible solutions with portmgr = members, I've chosen one, that while not ideal, have solved the issue = for now without creating other issues in future, that is to bump the = master www/nginx revision. >>=20 >> Hope that helps. >=20 > Hi Bartek, >=20 > Please don't bump PORTREVISION on www/nginx when you need to do so > in www/nginx-full. Sergey, I tried to explain you why it was necessary - it wasn't my 'oh, I just = want to bump some ports revisions' spree. It was discussed with portmgr = members and approved with adamw@. This is how master/slave relationship = works in our ports and there was no other better way around it. Hope = you'll understand that and accept it in future, where similar action = would be required. Kind regards, Bartek Rutkowski=