From owner-freebsd-ports  Fri Feb 22 11:49:29 2002
Delivered-To: freebsd-ports@freebsd.org
Received: from alcatraz.iptelecom.net.ua (alcatraz.iptelecom.net.ua [212.9.224.15])
	by hub.freebsd.org (Postfix) with ESMTP id 33AB337B42F
	for <freebsd-ports@FreeBSD.org>; Fri, 22 Feb 2002 11:48:57 -0800 (PST)
Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5])
	by alcatraz.iptelecom.net.ua (8.9.3/8.9.3) with ESMTP id VAA08278;
	Fri, 22 Feb 2002 21:48:03 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Received: from vega.vega.com (h65.227.dialup.iptcom.net [212.9.227.65])
	by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id VAA47857;
	Fri, 22 Feb 2002 21:47:56 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1])
	by vega.vega.com (8.11.6/8.11.3) with ESMTP id g1MJZPs12956;
	Fri, 22 Feb 2002 21:35:25 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <3C769D95.45D8A415@FreeBSD.org>
Date: Fri, 22 Feb 2002 21:35:49 +0200
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Vega International Capital
X-Mailer: Mozilla 4.79 [en] (Windows NT 5.0; U)
X-Accept-Language: en,uk,ru
MIME-Version: 1.0
To: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx>
Cc: drosih@rpi.edu, freebsd-ports@FreeBSD.org
Subject: Re: Speeding up bsd.ports.mk
References: <3C73F34F.D9A58E8B@FreeBSD.org>
		<a51k3b$31a$1@kemoauc.mips.inka.de>
		<3C74B745.9D57D6A9@FreeBSD.org>
		<3C74BF4E.480E1D39@FreeBSD.org>
		<3C75260E.1F72E9F6@FreeBSD.org>
		<p05101410b89ae610a56c@[128.113.24.47]>
		<3C7544E3.2CC013B4@FreeBSD.org> <20020222002642.50912e5c.corecode@corecode.ath.cx>
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

Simon 'corecode' Schubert wrote:
> 
> On Thu, 21 Feb 2002 21:05:07 +0200 Maxim Sobolev <sobomax@FreeBSD.ORG>
> wrote:
> 
> > Thank you for giving it a try - your help is really appreciated!
> 
> i did not yet test it - but i believe this patch may break building
> ports which utilize dialog(1) to change the port building options:
> 
> it usually works this way:
> 
> $ make all
>   v
>   - make pre-{everything|fetch|extract} -> config script builds
>                                            Makefile.inc
>   - other make commands launched include now Makefile.inc because of a
>     .if exists(Makefile.inc)
>     .include "Makefile.inc"
>     .endif
>     this means sub-makes after the config script will suck in the just
>     generated settings.
> 
> this won't work any more if each step is not launched seperately but
> processed from within one make(1) process.
> 
> this at least affects 22 ports (simple grep ".include.*WRKDIR"|wc told
> this) and i think this is serious because IMO more ports should use
> dialog(1) when !defined(BATCH). (btw: also IMO ports with dialogs
> shouldn't default to some values when built -DBATCH but just should be
> skipped [see the ports.mk: IS_INTERACTIVE"], but this is another thing)

I see. It should be quite easy to extend my patch to fall-back to the
previous behaviour when IS_INTERACTIVE is defined. I'll do it and
submit updated patch soon.

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message