From owner-svn-src-all@FreeBSD.ORG  Thu May 21 16:45:25 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4BA70AC0;
 Thu, 21 May 2015 16:45:25 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 25C75169B;
 Thu, 21 May 2015 16:45:25 +0000 (UTC)
Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net
 [173.54.116.245])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id EE50DB962;
 Thu, 21 May 2015 12:45:23 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: d@delphij.net
Cc: Matthew Ahrens <matt@mahrens.org>, Alexander Kabaev <kabaev@gmail.com>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r282971 - in head/sys: kern sys
Date: Thu, 21 May 2015 11:34:23 -0400
Message-ID: <3628414.bIFniENAoC@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.1-STABLE; KDE/4.14.3; amd64; ; )
In-Reply-To: <555CFBFA.5040707@delphij.net>
References: <201505151350.t4FDocQT054144@svn.freebsd.org>
 <CAKUb7ivud+SEx9N3NPtWff7xSaKAprsFOVCpERdjZ8K-jHtZWA@mail.gmail.com>
 <555CFBFA.5040707@delphij.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 21 May 2015 12:45:24 -0400 (EDT)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 May 2015 16:45:25 -0000

On Wednesday, May 20, 2015 02:26:18 PM Xin Li wrote:
> I think we should also assert that no waiter remains when a conditional
> variable is destroyed (which also suggests that the memory may be freed
> shortly).  Otherwise we would either have modify after free or lost wakeups.

We already assert for this.  That is what the call to sleepq_lookup() is
checking for.  If there are any sleepers then there will be a sleepq
allocated for this cvp.

-- 
John Baldwin