From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Jan 21 02:10:10 2012
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 00B81106566C
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat, 21 Jan 2012 02:10:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id D115A8FC13
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat, 21 Jan 2012 02:10:09 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0L2A980089204
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sat, 21 Jan 2012 02:10:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0L2A9g9089203;
	Sat, 21 Jan 2012 02:10:09 GMT (envelope-from gnats)
Resent-Date: Sat, 21 Jan 2012 02:10:09 GMT
Resent-Message-Id: <201201210210.q0L2A9g9089203@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	NAGATA Shinya <maya@negeta.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EFC3D106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat, 21 Jan 2012 02:03:07 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id DF3D68FC0C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Sat, 21 Jan 2012 02:03:07 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0L237TG044261
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 21 Jan 2012 02:03:07 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0L237rg044253;
	Sat, 21 Jan 2012 02:03:07 GMT (envelope-from nobody)
Message-Id: <201201210203.q0L237rg044253@red.freebsd.org>
Date: Sat, 21 Jan 2012 02:03:07 GMT
From: NAGATA Shinya <maya@negeta.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: ports/164347: comms/lrzsz fails to send ymodem
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jan 2012 02:10:10 -0000


>Number:         164347
>Category:       ports
>Synopsis:       comms/lrzsz fails to send ymodem
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 21 02:10:09 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     NAGATA Shinya
>Release:        FreeBSD 8.2
>Organization:
>Environment:
>Description:
YMODEM sends block0 to notify END OF TRANSFER.
But block0 includes invalid non-NULL data.
Because
struct stat f;
doesn't initialize f.st_size. The file size is exist, it is recognized as valid file transfer block.
>How-To-Repeat:
lsz --ymodem foo.txt
>Fix:
Initialize f.st_size.

Patch attached with submission follows:

--- src/lsz.c.orig	1998-12-30 07:07:59.000000000 +0900
+++ src/lsz.c	2012-01-21 10:44:49.000000000 +0900
@@ -1191,6 +1191,7 @@
 	struct stat f;
 
 	name2=alloca(PATH_MAX+1);
+	f.st_size = 0;
 
 	if (protocol==ZM_XMODEM) {
 		if (Verbose && *zi->fname && fstat(fileno(input_f), &f)!= -1) {


>Release-Note:
>Audit-Trail:
>Unformatted: