From owner-p4-projects Mon Dec 2 1:58:37 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id D3F2E37B404; Mon, 2 Dec 2002 01:58:35 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 81ED037B401 for ; Mon, 2 Dec 2002 01:58:35 -0800 (PST) Received: from herring.nlsystems.com (mailgate.nlsystems.com [62.49.251.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id BAFAA43ED8 for ; Mon, 2 Dec 2002 01:58:33 -0800 (PST) (envelope-from dfr@nlsystems.com) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by herring.nlsystems.com (8.12.6/8.12.6) with ESMTP id gB29wVqK006014; Mon, 2 Dec 2002 09:58:31 GMT (envelope-from dfr@nlsystems.com) Content-Type: text/plain; charset="iso-8859-1" From: Doug Rabson To: Marcel Moolenaar Subject: Re: PERFORCE change 21719 for review Date: Mon, 2 Dec 2002 09:58:30 +0000 User-Agent: KMail/1.4.3 Cc: Perforce Change Reviews References: <200211302059.gAUKxkZZ077084@repoman.freebsd.org> <200212011011.33999.dfr@nlsystems.com> <20021201185017.GA4331@dhcp01.pn.xcllnt.net> In-Reply-To: <20021201185017.GA4331@dhcp01.pn.xcllnt.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: <200212020958.30876.dfr@nlsystems.com> X-Spam-Status: No, hits=-7.7 required=5.0 tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,SPAM_PHRASE_00_01, USER_AGENT,USER_AGENT_KMAIL version=2.41 Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sunday 01 December 2002 6:50 pm, Marcel Moolenaar wrote: > On Sun, Dec 01, 2002 at 10:11:33AM +0000, Doug Rabson wrote: > > On Saturday 30 November 2002 8:59 pm, Marcel Moolenaar wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=3D21719 > > > > > > Change 21719 by marcel@marcel_nfs on 2002/11/30 12:58:56 > > > > > > =09Remove isa and BOOTP_*. > > > =09Comment out sio. > > > > > > =09The UART hardware is not supported by the sio driver. It is > > > =09probed with some hackery, but the sio driver is in essense > > > =09too ISA/i386 oriented (pretty much like fb/vga/sc). > > > > In what way? > > It assumes the UART uses I/O. The isa_irq_pending() function is also > an example of an ISA dependency. The latter does not prevent the sio > driver from working, but it does cause an annoying message at boot. > > > The sio driver itself just assumes that it can use > > bus_space to access a standard 16550 uart or similar. The bus > > attachment code (sio_isa, sio_pccard, sio_ebus etc.) contains any > > code which is bus-related. This driver works quite well on five > > different busses - what does the HP machine do that is different? > > For one, it hasn't got any ISA busses. Secondly, the Diva comm board > is memory mapped. In sioprobe() we assume I/O. It's also a multiport > board and we also don't seem to have the framework yet to just tell > it the characteristics of this board as the Linux driver has. I'm sorry - I thought that the thing was converted to bus_space when it=20 grew all the non-isa bus attachments. This really needs to happen to=20 make the driver portable. I'm not sure what to do with the=20 isa_irq_pending call - probably migrate it to the isa attachment. --=20 Doug Rabson=09=09=09=09Mail: dfr@nlsystems.com =09=09=09=09=09Phone: +44 20 8348 6160 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message