From nobody Wed Mar 6 16:59:36 2024 X-Original-To: freebsd-pkgbase@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tqdvj1R6Wz5Cw9k for ; Wed, 6 Mar 2024 16:59:45 +0000 (UTC) (envelope-from marquis@roble.com) Received: from mx5.roble.com (mx5.roble.com [209.237.23.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx5.roble.com", Issuer "mx5.roble.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tqdvh5c7yz4l2r; Wed, 6 Mar 2024 16:59:44 +0000 (UTC) (envelope-from marquis@roble.com) Authentication-Results: mx1.freebsd.org; none Received: from roble.com (roble.com [209.237.23.50]) by mx5.roble.com (Postfix) with ESMTP id 72D01D288; Wed, 6 Mar 2024 08:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=roble.com; s=rs060402; t=1709744376; bh=jV2V3wYFE+e8q98fxeieMDyE74ihy/dDjv462YUvexc=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=BB4IiugLQn6j7ri2gIvkcBTJ2hxpVZMxOdndO5a3K6WCvYO0ArD1gvrk34iH+Odbb yORZ6Fh9Htardr2aYjmlWl/tfIjqeAcqS5kScTMwNBoMRme4yQMbW5ph5gH3S9YTCP zEpt1RJbIwYF2eLZdd3CJcZAsNG6kbu2XVg+7OFc= Date: Wed, 6 Mar 2024 08:59:36 -0800 (PST) From: Roger Marquis To: Baptiste Daroussin cc: Graham Perrin , freebsd-pkgbase@freebsd.org Subject: Re: pkgbase and config file merges In-Reply-To: <2i4vs2rmlpqssl5wyrzhn5izyvuoxz2rmfjbjlaaq6exuqbllm@e436o6dw7nx3> Message-ID: <5ns1p95s-n316-22qs-63p2-q6246q043802@mx.roble.com> References: <8137de78-e205-4e7c-a25b-700045b3c950@gmail.com> <2i4vs2rmlpqssl5wyrzhn5izyvuoxz2rmfjbjlaaq6exuqbllm@e436o6dw7nx3> List-Id: Packaging the FreeBSD base system List-Archive: https://lists.freebsd.org/archives/freebsd-pkgbase List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkgbase@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:17403, ipnet:209.237.0.0/18, country:US] X-Rspamd-Queue-Id: 4Tqdvh5c7yz4l2r Automatically overwriting files like passwd is clearly a problem. Preferred solution would be a list, say [never_overwrite] and/or [ask before overwriting] and/or [write diff to /var/db/pkgbase/...] in /etc/defaults/pkgbase specifying existing files that should never be modified without at least a dialog. This plus the cleanup of pkgsave files which should only be written to /var/db/pkgbase/pkgsave/`date +%G%m%d%H%M` should address the blockers to more widespread adoption of packagebase and, ideally, make it mandatory or at least the default option in the next version of FreeBSD. Roger > On Tue, Mar 05, 2024 at 06:02:41AM +0000, Graham Perrin wrote: >> On 04/03/2024 10:14, Baptiste Daroussin wrote: >>>> ? >>> Pkg has 3-way merge code, so it is similar to etcupdate(8) provided the file is >>> properly marked as a config file i the source tree which is the case of >>> master.passwd >>> >>> Best regards, >>> Bapt >> >> Thanks, that's a very pleasant surprise, is >> outdated? >> >> (Answered in 2012; .) > > No this is not outdated. >> >> Is still, partly, an issue? >> >> ? pkg(8) deinstall and then reinstall of FreeBSD-runtime leads to wiping out >> `/etc/master.passwd` and `/etc/group` ? Issue #1845 ? freebsd/pkg >> > this is not an issue, this is expected. > > Best regards, > Bapt >> > > > >