From owner-freebsd-current  Fri Jun 29 11:11:55 2001
Delivered-To: freebsd-current@freebsd.org
Received: from tasogare.imasy.or.jp (tasogare.imasy.or.jp [202.227.24.5])
	by hub.freebsd.org (Postfix) with ESMTP
	id 97F2137B403; Fri, 29 Jun 2001 11:11:51 -0700 (PDT)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from localhost (iwasaki.imasy.or.jp [202.227.24.92])
	by tasogare.imasy.or.jp (8.11.3+3.4W/8.11.3/tasogare) with ESMTP/inet id f5TIBmI74623;
	Sat, 30 Jun 2001 03:11:48 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
To: acpi-jp@jp.freebsd.org, msmith@freebsd.org
Cc: current@freebsd.org
Subject: Re: [acpi-jp 1150] HEADS UP: ACPI update - thermal management
In-Reply-To: <200106280635.f5S6Z7w07241@mass.dis.org>
References: <200106280635.f5S6Z7w07241@mass.dis.org>
X-Mailer: Mew version 1.94.1 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20010630031147Q.iwasaki@jp.FreeBSD.org>
Date: Sat, 30 Jun 2001 03:11:47 +0900
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
X-Dispatcher: imput version 20000228(IM140)
Lines: 35
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

Hi, mike.

> This is just a heads-up to let folks know that I've committed some early 
> code to handle thermal management under ACPI.  This should DTRT with 
> active cooling (fans, etc.).  It won't help with passive cooling yet (we 
> need to sort out the processor device control first), and it may well 
> have problems (there are places where the specification is vague about 
> what should be in the namespace and my ability to test these options is 
> limited).

I tested this a bit and noticed following messages.

	unknown: error fetching current temperature

I think that notify handler got wrong parameter, device_t not softc.
Here is the fix for it.

Index: acpi_thermal.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/acpica/acpi_thermal.c,v
retrieving revision 1.8
diff -u -r1.8 acpi_thermal.c
--- acpi_thermal.c      2001/06/28 06:17:16     1.8
+++ acpi_thermal.c      2001/06/29 17:48:14
@@ -151,7 +151,7 @@
      * Register for any Notify events sent to this zone.
      */
     AcpiInstallNotifyHandler(sc->tz_handle, ACPI_DEVICE_NOTIFY, 
-			      acpi_tz_notify_handler, dev);
+			      acpi_tz_notify_handler, sc);

BTW, how about sysctl interface for ACPI thermal zone?
At least the representative temperature would be useful for users.

Thanks

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message