From owner-cvs-src@FreeBSD.ORG Mon Apr 18 08:04:46 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B3BE216A4CE; Mon, 18 Apr 2005 08:04:46 +0000 (GMT) Received: from ylpvm29.prodigy.net (ylpvm29-ext.prodigy.net [207.115.57.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D16B43D5C; Mon, 18 Apr 2005 08:04:46 +0000 (GMT) (envelope-from julian@elischer.org) Received: from pimout1-ext.prodigy.net (pimout1-ext.prodigy.net [207.115.63.77])j3I849O4017653; Mon, 18 Apr 2005 04:04:10 -0400 X-ORBL: [68.124.205.128] Received: from [192.168.2.2] (adsl-68-124-205-128.dsl.snfc21.pacbell.net [68.124.205.128])j3I84gm1164056; Mon, 18 Apr 2005 04:04:43 -0400 Message-ID: <42636A16.2070702@elischer.org> Date: Mon, 18 Apr 2005 01:04:38 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.5) Gecko/20050214 X-Accept-Language: en, hu MIME-Version: 1.0 To: obrien@FreeBSD.org References: <200504161543.j3GFhclO075103@repoman.freebsd.org> <86acnyd2k7.fsf@xps.des.no> <20050418063321.GA85819@dragon.NUXI.org> In-Reply-To: <20050418063321.GA85819@dragon.NUXI.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= cc: src-committers@FreeBSD.org cc: Giorgos Keramidas cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/top machine.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2005 08:04:46 -0000 David O'Brien wrote: > On Sat, Apr 16, 2005 at 08:00:40PM +0200, Dag-Erling Smrgrav wrote: > >>Giorgos Keramidas writes: >> >>> Log: >>> Reduce the width of the THR column to 4 characters, to avoid wrap-around >>> of lines in SMP machines (which are wider), until we have a better way >>> of handling window sizes & columns in top. >> >>We should probably drop the CPU column (WCPU should suffice), > > > No, 'CPU' is quite useful on SMP machines. except for multi threaded apps my suggestion is to use [CPU] if it's a CPU number (implying Nthreads == 1) and THREADNUM if it's multithreaded.. so th column might read: [0] [2] [3] [0] 134 [0] [1] [0] 3 if you hit 'H' so that every thread gets a line, then you only see the [CPUNUM] versions so it looks as it does now. (except for the '[' and ']') >