Date: Thu, 04 May 2006 15:25:52 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Jean-Yves Lefort <jylefort@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/astro/celestia Makefile distinfo pkg-message.gnome pkg-plist ports/astro/celestia/files patch-config.h.in patch-src_celestia_Makefile.in patch-src_celestia_gtkmain.cpp patch-src_celutil_resmanager.h patch-src_celutil_util.h Message-ID: <1146749152.18447.14.camel@pav.hide.vol.cz> In-Reply-To: <20060504151740.62d5d719.jylefort@FreeBSD.org> References: <200605041238.k44CcbRf005669@repoman.freebsd.org> <1146746599.18447.11.camel@pav.hide.vol.cz> <20060504151740.62d5d719.jylefort@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-5cQMLxzZyvtvrN8rrNMk Content-Type: text/plain; charset=ISO8859-2 Content-Transfer-Encoding: quoted-printable Jean-Yves Lefort p=ED=B9e v =E8t 04. 05. 2006 v 15:17 +0200: > On Thu, 04 May 2006 14:43:19 +0200 > Pav Lucistnik <pav@FreeBSD.org> wrote: >=20 > > Jean-Yves Lefort p=ED=B9e v =E8t 04. 05. 2006 v 12:38 +0000: > > > jylefort 2006-05-04 12:38:37 UTC > > >=20 > > > FreeBSD ports repository > > >=20 > > > Modified files: > > > astro/celestia Makefile distinfo=20 > > > Added files: > > > astro/celestia pkg-message.gnome pkg-plist=20 > > > astro/celestia/files patch-config.h.in=20 > > > patch-src_celestia_Makefile.in=20 > > > patch-src_celutil_util.h=20 > > > Removed files: > > > astro/celestia/files patch-src_celestia_gtkmain.cpp=20 > > > patch-src_celutil_resmanager.h=20 > >=20 > > > - Do not use OPTIONS for the mutually exclusive UI choices, use > >=20 > > Your usage of OPTIONS is incorrect. For default on options, you have to > > test WITHOUT_* variable. Please refer for more details to > > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.h= tml >=20 > Why? When you bypass OPTIONS completely (using BATCH or PACKAGE_BUILD), no OPTIONS related variables are created. Your tests must do the "default" thing when no variables were created. Otherwise pointyhat packages will have non-default properties. At the moment, no WITH_LUA nor WITHOUT_LUA variable is created when using BATCH, and your test .if WITH_LUA will fail. Such package will end without Lua support, even when you specified the option to default to "on". --=20 Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> A cow is a sphere that emits milk into all directions. At least to a first approximation. -- An unknown physicist --=-5cQMLxzZyvtvrN8rrNMk Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?= =?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEWgDgntdYP8FOsoIRAikxAJ9PmaOAKhjxELstA4oLKgTMauFjwACfbyaF sPjGLE/792cV6eQaFu8W1wI= =u1Sr -----END PGP SIGNATURE----- --=-5cQMLxzZyvtvrN8rrNMk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1146749152.18447.14.camel>