From nobody Sat May 30 17:09:41 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gSRYf1pclz6gJtJ; Sat, 30 May 2026 17:10:14 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Received: from smtp052.goneo.de (smtp052.goneo.de [85.220.129.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4gSRYd6dhjz43sl; Sat, 30 May 2026 17:10:13 +0000 (UTC) (envelope-from freebsd@walstatt-de.de) Authentication-Results: mx1.freebsd.org; none Received: from hub2.goneo.de (hub2.goneo.de [IPv6:2001:1640:5::8:53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by smtp5.goneo.de (Postfix) with ESMTPS id 8A27A24006B; Sat, 30 May 2026 19:10:11 +0200 (CEST) Received: from hub2.goneo.de (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPS id AF5C92400C0; Sat, 30 May 2026 19:10:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walstatt-de.de; s=DKIM001; t=1780161009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mU3E0sqO6eqcimr6COU10RXMUsfQ9lq9vRBlN76jmRI=; b=stcVC1FFsbmqybCDZERVcaG0YIS93kJrTEfjtuht1FtRmbU7Irzj8AriIK3bR2XUDpgTki 7J3Y6H924dJ5nPXZRkLDebRgMr/aaS0hnNFAtvXfkuzp3eC1TtCsZVV9g+0FpUIDiIMWng sLwPkXkSgD98RT91AC3bRnygLTKuriJcx34HYwkPvcDD/oDuGBCBrRMgoy3D4WfvVOUDjF hiHKp2gjL+2jbMmFVGTKIM/VmM3CRSGVbltnYs2/RcJJlwXd67LzZya56Coe3dmXM5+qYq kU4tk+YhpLO/evTv62rVAtTuAYuRKFjwwzQezAR0VKMeYnfKPBit+WfRVy4W4Q== Received: from thor.sb211.local (dynamic-2a02-3100-2914-f002-f829-ceb9-7bc5-38a6.310.pool.telefonica.de [IPv6:2a02:3100:2914:f002:f829:ceb9:7bc5:38a6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hub2.goneo.de (Postfix) with ESMTPSA id 672EC2400A3; Sat, 30 May 2026 19:10:09 +0200 (CEST) Date: Sat, 30 May 2026 19:09:41 +0200 From: A FreeBSD User To: Ahmad Khalifa Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2fa4bdd7f9e9 - main - edk2: enable static asserts for *INT64 alignment Message-ID: <20260530190827.15ba6ffa@thor.sb211.local> In-Reply-To: <6a1a4f38.32b9d.5eb5f95e@gitrepo.freebsd.org> References: <6a1a4f38.32b9d.5eb5f95e@gitrepo.freebsd.org> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; amd64-portbld-freebsd16.0) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/r5c_p4JoWm=Ug=VaTk6XtMQ"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Rspamd-UID: e855a6 X-Rspamd-UID: c4fcf6 X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:25394, ipnet:85.220.128.0/17, country:DE] X-Rspamd-Queue-Id: 4gSRYd6dhjz43sl X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --Sig_/r5c_p4JoWm=Ug=VaTk6XtMQ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Tage des Herren Sat, 30 May 2026 02:45:12 +0000 Ahmad Khalifa schrieb: > The branch main has been updated by vexeduxr: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D2fa4bdd7f9e99698a6652db405= c3165fdcd41c1d >=20 > commit 2fa4bdd7f9e99698a6652db405c3165fdcd41c1d > Author: Ahmad Khalifa > AuthorDate: 2026-05-30 02:40:58 +0000 > Commit: Ahmad Khalifa > CommitDate: 2026-05-30 02:40:58 +0000 >=20 > edk2: enable static asserts for *INT64 alignment > =20 > The ia32 loader is now built with -malign-double, so these should pas= s. > =20 > Differential Revision: https://reviews.freebsd.org/D55386 > --- > sys/contrib/edk2/Include/Base.h | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/sys/contrib/edk2/Include/Base.h b/sys/contrib/edk2/Include/B= ase.h > index 3ae798db8429..d3342c9a6ca2 100644 > --- a/sys/contrib/edk2/Include/Base.h > +++ b/sys/contrib/edk2/Include/Base.h > @@ -841,10 +841,8 @@ STATIC_ASSERT (ALIGNOF (INT16) =3D=3D sizeof (INT1= 6), "Alignment of INT16 > does not STATIC_ASSERT (ALIGNOF (UINT16) =3D=3D sizeof (UINT16), "Alignm= ent of UINT16 does not > meet UEFI Specification Data Type requirements"); STATIC_ASSERT (ALIGNOF = (INT32) =3D=3D sizeof > (INT32), "Alignment of INT32 does not meet UEFI Specification Data Type r= equirements"); > STATIC_ASSERT (ALIGNOF (UINT32) =3D=3D sizeof (UINT32), "Alignment of UI= NT32 does not meet UEFI > Specification Data Type requirements"); -#ifndef _STANDALONE STATIC_ASSER= T (ALIGNOF (INT64) > =3D=3D sizeof (INT64), "Alignment of INT64 does not meet UEFI Specificat= ion Data Type > requirements"); STATIC_ASSERT (ALIGNOF (UINT64) =3D=3D sizeof (UINT64), = "Alignment of UINT64 > does not meet UEFI Specification Data Type requirements"); -#endif STATIC= _ASSERT (ALIGNOF > (CHAR8) =3D=3D sizeof (CHAR8), "Alignment of CHAR8 does not meet UEFI S= pecification Data Type > requirements"); STATIC_ASSERT (ALIGNOF (CHAR16) =3D=3D sizeof (CHAR16), = "Alignment of CHAR16 > does not meet UEFI Specification Data Type requirements"); STATIC_ASSERT = (ALIGNOF (INTN) > =3D=3D sizeof (INTN), "Alignment of INTN does not meet UEFI Specification= Data Type > requirements"); >=20 The commit seems to disturb building process and gets rogue with: [...] In file included from /usr/src/sys/contrib/edk2/Include/Uefi/UefiBaseType.h= :16: /usr/src/sys/contrib/edk2/Include/Base.h:844:16: error: static assertion fa= iled due to requirement '_Alignof(long long) =3D=3D sizeof(long long)': Alignment of IN= T64 does not meet UEFI Specification Data Type requirements 844 | STATIC_ASSERT (ALIGNOF (INT64) = =3D=3D sizeof (INT64), "Alignment of INT64 does not meet UEFI Specification Data Type requirements= "); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/sys/contrib/edk2/Include/Base= .h:778:24: note: expanded from macro 'ALIGNOF' Regards oh --=20 A FreeBSD user --Sig_/r5c_p4JoWm=Ug=VaTk6XtMQ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRQheDybVktG5eW/1Kxzvs8OqokrwUCahsZ8AAKCRCxzvs8Oqok rz4hAP9yqU+prSppICEdHlll+zLvhuFrL93v14mzLqjgT4lurwD9HCvm9b366jFl CTSGA8bktKQNvGrBVNrIwaQd1Hu/iw0= =VMWX -----END PGP SIGNATURE----- --Sig_/r5c_p4JoWm=Ug=VaTk6XtMQ--