Date: Fri, 24 Mar 2006 11:03:26 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Kris Kennaway <kris@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_socket.c Message-ID: <20060324110251.U75728@fledge.watson.org> In-Reply-To: <200603232258.k2NMwgRN018180@repoman.freebsd.org> References: <200603232258.k2NMwgRN018180@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 23 Mar 2006, Kris Kennaway wrote: > Fix a bug in the NFS/TCP retransmission path. > > The bug was that earlier, if a request was retransmitted, > we would do subsequent retransmits every 10 msecs. > > This can cause data corruption under moderate loads by reordering > operations as seen by the client NFS attribute cache, and on the > server side when the retransmission occurs after the original request > has left the duplicate cache, since the operation will be committed > for a second time. > > Further work on retransmission handling is needed (e.g. they are still > being done sent too often since they are scaled by HZ, and the size of > the dup cache is too small and easily overwhelmed on busy servers). Wow. Nice catch. Robert N M Watson
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060324110251.U75728>