From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jun 4 08:40:10 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0BABC106564A for ; Sat, 4 Jun 2011 08:40:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D5F518FC19 for ; Sat, 4 Jun 2011 08:40:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p548e9dl087682 for ; Sat, 4 Jun 2011 08:40:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p548e97I087681; Sat, 4 Jun 2011 08:40:09 GMT (envelope-from gnats) Resent-Date: Sat, 4 Jun 2011 08:40:09 GMT Resent-Message-Id: <201106040840.p548e97I087681@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Chris Rees Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA902106564A for ; Sat, 4 Jun 2011 08:35:58 +0000 (UTC) (envelope-from utisoft@hotmail.com) Received: from blu0-omc1-s21.blu0.hotmail.com (blu0-omc1-s21.blu0.hotmail.com [65.55.116.32]) by mx1.freebsd.org (Postfix) with ESMTP id 722A88FC16 for ; Sat, 4 Jun 2011 08:35:58 +0000 (UTC) Received: from BLU0-SMTP48 ([65.55.116.9]) by blu0-omc1-s21.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 4 Jun 2011 01:35:58 -0700 Received: from zeus.bayofrum.net ([90.221.7.100]) by BLU0-SMTP48.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 4 Jun 2011 01:35:56 -0700 Received: from zeus.bayofrum.net (crees@localhost [127.0.0.1]) by zeus.bayofrum.net (8.14.4/8.14.4) with ESMTP id p548YDUa075734 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO) for ; Sat, 4 Jun 2011 09:34:14 +0100 (BST) (envelope-from chris@zeus.bayofrum.net) Received: (from crees@localhost) by zeus.bayofrum.net (8.14.4/8.14.4/Submit) id p548YDAI075733; Sat, 4 Jun 2011 09:34:13 +0100 (BST) (envelope-from chris) Message-Id: Date: Sat, 4 Jun 2011 09:34:13 +0100 From: Chris Rees Sender: To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/157578: [PATCH] Fix port: dns/dnrd should use USERS X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Chris Rees List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jun 2011 08:40:10 -0000 >Number: 157578 >Category: ports >Synopsis: [PATCH] Fix port: dns/dnrd should use USERS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Jun 04 08:40:09 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Chris Rees >Release: FreeBSD 8.2-RELEASE-p1 i386 >Organization: bayofrum >Environment: System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386 >Description: This port uses pkg-install to create new users instead of using USERS= and GROUPS=. >How-To-Repeat: >Fix: - Use USERS and GROUPS Submitted by: Chris Rees (utisoft@gmail.com) This depends on ports/157528 for the UIDs patch --- dns-dnrd.patch begins here --- Index: Makefile =================================================================== RCS file: /exports/cvsroot-freebsd/ports/dns/dnrd/Makefile,v retrieving revision 1.30 diff -u -r1.30 Makefile --- Makefile 21 Aug 2008 06:16:53 -0000 1.30 +++ Makefile 2 Jun 2011 15:16:50 -0000 @@ -28,14 +28,12 @@ DEBUG "Enable debugging" off \ RANDOM "Enable random source port" off -DNRD_USER?= dnrd -DNRD_GROUP?= dnrd +USERS= dnrd +GROUPS= dnrd DNRD_DIR?= ${ETCDIR} SUB_FILES= pkg-install -SUB_LIST+= DNRD_USER=${DNRD_USER} \ - DNRD_GROUP=${DNRD_GROUP} \ - DNRD_DIR=${DNRD_DIR} +SUB_LIST+= DNRD_DIR=${DNRD_DIR} .include @@ -55,10 +53,6 @@ CONFIGURE_ARGS+= --enable-random-src .endif -pre-install: - @${ECHO} "==> Creating custom user to run dnrd..." - @${SETENV} PKG_PREFIX="${PREFIX}" ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL - do-install: @${ECHO} "==> Creating dnrd directory" @${SETENV} PKG_PREFIX="${PREFIX}" ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL Index: pkg-install =================================================================== RCS file: /exports/cvsroot-freebsd/ports/dns/dnrd/pkg-install,v retrieving revision 1.1 diff -u -r1.1 pkg-install --- pkg-install 6 Sep 2005 12:10:46 -0000 1.1 +++ pkg-install 2 Jun 2011 15:14:30 -0000 @@ -1,34 +1,9 @@ #!/bin/sh -USER=${DNRDUSER:-dnrd} -GROUP=${USER} SYSCONF_DIR=${SYSCONF_DIR:-${PKG_PREFIX}/etc/dnrd} case $2 in - PRE-INSTALL) - if ! pw groupshow "${GROUP}" 2>/dev/null 1>&2; then - if pw groupadd ${GROUP}; then - echo "Added group \"${GROUP}\"." - else - echo "Adding group \"${GROUP}\" failed..." - exit 1 - fi - fi - - if ! pw usershow "${USER}" 2>/dev/null 1>&2; then - if pw useradd ${USER} -g ${GROUP} -h - \ - -s "/sbin/nologin" -d "/var/empty" \ - -c "DNRD daemon"; \ - then - echo "Added user \"${USER}\"." - else - echo "Adding user \"${USER}\" failed..." - exit 1 - fi - fi - ;; - POST-INSTALL) if [ ! -d ${SYSCONF_DIR} ]; then mkdir -p ${SYSCONF_DIR} --- dns-dnrd.patch ends here --- -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. >Release-Note: >Audit-Trail: >Unformatted: